[WIP] USGS basin scaling for each US 2023 sub GMM #10154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CB-quakemodel
changed the title
micheles
reviewed
Nov 15, 2024
| self.usgs_basin_scaling = usgs_basin_scaling | ||
| if (self.usgs_basin_scaling and 'z2pt5' not in | ||
| self.REQUIRES_SITES_PARAMETERS): | ||
| raise ValueError('User must specify a GSIM class for this GMPE ' |
There was a problem hiding this comment.
Maybe the error message came from the ModifiableGMPE? It does not make sense here.
There was a problem hiding this comment.
The user might specify to use the US basin scaling, but specify a class of this GMM which does not consider basin effects (especially for this gsim where there is ParkerEtAl2020SInterface and ParkerEtAl2020SInterB, and so I think a warning might be a good idea to highlight this?
There was a problem hiding this comment.
By a class of this GMM do you mean a subclass?
There was a problem hiding this comment.
Ah yes I mean a subclass
micheles
reviewed
Nov 15, 2024
micheles
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add the USGS basin scaling adjustments to each of the required subduction GMMs in the 2023 US model.
To do:
utils_usgs_basin_scaling.py