Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site response models + modification to Modifiable GMPE for AUS23 #10155

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mmpagani
Copy link
Member

@mmpagani mmpagani commented Nov 15, 2024

The AUS23 model uses a tabular GMM with fixed values of vs30. This does not permit computing hazard using spatially variable site conditions. This PR adds to OQ the linear and non-linear amplification terms used by GA to create the tabular GMMs. It also provides a function in the modifiable GMPE that permits using these two amplification terms.

We performed tests comparing the ground motion computed with the modifiable GMPE and the values available in the original tables distributed by GA (see https://ecat.ga.gov.au/geonetwork/srv/eng/catalog.search#/metadata/149177)

@g-weatherill
Copy link
Collaborator

g-weatherill commented Nov 15, 2024

The Hashash et al. (2020) and the Stewart et al. (2020) amplification models (and their epistemic uncertainties) were already implemented in the functions associated to the NGA East Base class (unless there has been an update to them). https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/nga_east.py#L349 to https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/nga_east.py#L517. If you are implementing the same functions again in separate files then I guess it would be useful to update the NGA East classes to call those functions from the separate files rather than have duplicate code.

@micheles micheles added this to the Engine 3.22.0 milestone Nov 15, 2024
@mmpagani
Copy link
Member Author

@g-weatherill thanks. I completely missed them. I will check what you did back then and compare it to the code I prepared.

@g-weatherill
Copy link
Collaborator

@mmpagani I was initially thinking about just updating the NGA East class to refer to the functions in the files you are adding in this PR, but actually I'm seeing there will be some downstream consequences to doing that. The site amplification functions in the NGA East were implemented with their epistemic uncertainties, and these epistemic uncertainties are used as part of the ESHM20 logic tree for the craton region (https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/eshm20_craton.py#L68) and for the USGS CEUS logic tree (https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/usgs_ceus_2019.py#L253). So maybe it would be sensible to keep the two separate implementations initially and then expand the new implementation to include the epistemic uncertainties in amplification in a future PR where you can propagate the changes into the other affected classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants