Verification test suite for the conditioned GMF calculator #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor refactoring to move the ConditionedGmfComputer from the hazardlib/shakemap module to hazardlib/calc, which is the more appropriate location for the class, given the extent of code shared with the regular GmfComputer. The shakemap module instead is better suited to support the different implementations of ShakeMap, including ones run by the Swiss Seismological Servicehazardlib/calc, which is the more appropriate location for the class, given the extent of code shared with the regular GmfComputer. The shakemap module instead is better suited to support the different implementations of ShakeMap, including ones run by the Swiss Seismological Service (SED) in Switzerland, INGV in Italy, Institute of Engineering Seismology and Earthquake Engineering (ITSAK) in Greece, and ShakeMapEU.
Test cases 01–10 are based on the verification tests described in the USGS ShakeMap 4.1 Manual. Ref: Worden, C. B., E. M. Thompson, M. Hearne, and D. J. Wald (2020). ShakeMap Manual Online: technical manual, user’s guide, and software guide, U.S. Geological Survey. DOI: https://doi.org/10.5066/F7D21VPQ, see https://usgs.github.io/shakemap/manual4_0/tg_verification.html`.
And switch to numpy.testing.assert_allclose for all checks in previous cases
Case not tested, but used for generating a plot for comparison
These three cases are included for plotting purposes only No assertions are made for these tests
These two cases are used for plotting purposes only. No assertions are made for these test cases.
cov_BD_BD_yD should not have a sqrt Spotted by @VSilva
micheles
approved these changes
Mar 20, 2023
…uals Resolves the discrepancy in case_06
|
Updated case_07 plots
|
|
The case_06 discrepancy is due to the parameter Updated case_06 plots
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a set of verification tests for the conditioned GMF calculator. Final part of #8317. This test set currently replicates the set of well-designed simplified verification tests used by the ShakeMap model module.
In addition, this PR also makes the following changes to the conditioned GMF calculator:
nominal_bias_stddev(avoid a double sqrt)Plots of the test case results are shown in the table below: