fix: correctly require plugins with yarn+pnp (for all versions) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Sep 10, 2024
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| // helper for convenient testing | |||
| exports.require = (name) => { | |||
| const importedModule = require(require.resolve(name, {paths: [process.cwd()]})); // Require module using the absolute path | |||
| const defaultPathsToResolve = require.resolve.paths(name); | |||
| const absoluteModulePath = require.resolve(name, {paths: [process.cwd(), ...defaultPathsToResolve]}); | |||
There was a problem hiding this comment.
Found a bug which was reproduced for user with [email protected], plugin is not found in process.cwd, but found in default folders from require.resolve.paths. So I fixed it.
There was a problem hiding this comment.
Jfyi: after this one we would not need to create symlinks for testing-project/node_modules 🔥
sipayRT
approved these changes
Sep 12, 2024
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| // helper for convenient testing | |||
| exports.require = (name) => { | |||
| const importedModule = require(require.resolve(name, {paths: [process.cwd()]})); // Require module using the absolute path | |||
| const defaultPathsToResolve = require.resolve.paths(name); | |||
There was a problem hiding this comment.
It just returns default path the plugin can be resolved to?
There was a problem hiding this comment.
Yes, and I can actually pass just an empty string there. But I decided to pass the package name just in case if something changed in next nodejs versions.
KuznetsovRoman
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.