Merge pull request #960 from gemini-testing/INFRADUTY-27136.test_error

fix: declare err property on Test type
gemini-testing · Jun 28, 2024 · e604e66 · e604e66
2 parents f9239c9 + ddb9988
commit e604e66
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/test-reader/test-object/test.ts b/src/test-reader/test-object/test.ts
@@ -8,6 +8,7 @@ type TestOpts = TestObjectData &
 
 export class Test extends ConfigurableTestObject {
     public fn: TestFunction<TestFunctionCtx>;
+    public err?: Error;
 
     static create<T extends Test>(this: new (opts: TestOpts) => T, opts: TestOpts): T {
         return new this(opts);

diff --git a/test/src/error-snippets/index.ts b/test/src/error-snippets/index.ts
@@ -53,9 +53,9 @@ describe("error-snippets", () => {
                 );
                 const originalStack = error.stack;
 
-                await extendWithCodeSnippet(error);
+                const result = await extendWithCodeSnippet(error);
 
-                assert.equal(error.stack, originalStack);
+                assert.isUndefined(result.snippet, originalStack);
             });
         });
 

diff --git a/test/src/runner/test-runner/regular-test-runner.js b/test/src/runner/test-runner/regular-test-runner.js
@@ -305,13 +305,14 @@ describe("runner/test-runner/regular-test-runner", () => {
                 const test = new Test({});
                 const onFail = sinon.stub().named("onFail");
                 const runner = mkRunner_({ test }).on(Events.TEST_FAIL, onFail);
+                const err = new Error();
 
                 const workers = mkWorkers_();
-                workers.runTest.rejects(new Error());
+                workers.runTest.rejects(err);
 
                 await run_({ runner, workers });
 
-                assert.calledOnceWith(onFail, sinon.match(test));
+                assert.calledOnceWith(onFail, sinon.match(Object.assign(test, { err })));
             });
 
             it("should be emitted with error", async () => {