Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EC to one-to-one-xrefs-by-value-violation #28070

Closed
pgaudet opened this issue Jun 10, 2024 · 22 comments
Closed

Fix EC to one-to-one-xrefs-by-value-violation #28070

pgaudet opened this issue Jun 10, 2024 · 22 comments
Assignees
Labels

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Jun 10, 2024

See PR here:
#26235

286 terms are failing. I made a spreadsheet here: https://docs.google.com/spreadsheets/d/17QvDQoIXe-Rim9ReReVlZGntr-WkIGJ0cbPhaQDB_As/edit#gid=0

@pgaudet
Copy link
Contributor Author

pgaudet commented Jun 10, 2024

  • EC:1.1.1.117 | GO:0106271 | GO:0045290: removed EC from GO:0106271 since EC not specific for NAD/NADP
  • EC:1.1.1.146 | GO:0070524 | GO:0102196: removed EC from GO:0102196 (too broad); added parent GO:0070524 ! 11-beta-hydroxysteroid dehydrogenase (NADP+) activity to match RHEA 'more general' reaction
  • EC:1.1.1.188 | GO:0047017 | GO:0036131: Removed EC from GO:0036131; EC seems non-directional but RHEA only maps to the 'synthase' direction
  • EC:1.1.1.195 | GO:0045551 | GO:0052747:
    +xref: RHEA:10392 : added {source="skos:narrowMatch"}
    +xref: RHEA:45704 {source="skos:narrowMatch"}
    +xref: RHEA:45724 {source="skos:narrowMatch"}
  • GO:0050268 coniferyl-alcohol dehydrogenase activity: change def xref to RHEA:22444
  • Obsolete GO:0052747 sinapyl alcohol dehydrogenase activity (only IEA annotations) + replace by GO:0045551 cinnamyl-alcohol dehydrogenase activity
  • EC:1.14.11.13 | GO:0052634 | GO:0045543: remove EC from GO:0052634 as this is a mre specific reaction. Kept activities because some plant enzymes seem to be specific for C-19 gibberellin versus C-20 gibberellin (see PMID:12509528)

@pgaudet
Copy link
Contributor Author

pgaudet commented Jun 12, 2024

  • EC:1.1.1.237 | GO:0102742 | GO:0047995: GO:0102742 R(+)-3,4-dihydroxyphenyllactate:NADP+ oxidoreductase activity >> replace by GO:0047995 hydroxyphenylpyruvate reductase activity; because GO:0102742 represents a specific substrate. No manual annotations
  • EC:1.1.1.303 | GO:0052587 | GO:0019152 >> removed EC from grouping class GO:0019152; should only have been on child GO:0052587
  • EC:1.1.1.304 | GO:0052588 | GO:0019152 >> removed EC from grouping class GO:0019152; should only have been on child GO:0052588
  • GO:1990137 plant seed peroxidase activity: fixed term label and def to match EC:1.11.2.3

pgaudet added a commit that referenced this issue Jun 12, 2024
pgaudet added a commit that referenced this issue Jun 12, 2024
obsoleted terms fixed xrefs for #28070 obsoleted term fixes #28049
pgaudet added a commit that referenced this issue Jun 12, 2024
pgaudet added a commit that referenced this issue Jun 12, 2024
pgaudet added a commit that referenced this issue Jun 12, 2024
pgaudet added a commit that referenced this issue Jun 12, 2024
@pgaudet
Copy link
Contributor Author

pgaudet commented Jun 13, 2024

  • GO:0000140 acylglycerone-phosphate reductase activity
  • changed label to acylglycerone-phosphate reductase (NADP+) activity
  • fixed xref scope: xref: RHEA:17341 {source="skos:exactMatch"}
  • added xref: RHEA:36175 {source="skos:narrowMatch"}
  • GO:0018529 nitrilotriacetate monooxygenase activity
    -fixed def from "Catalysis of the reaction: nitrilotriacetate + NADH + H+ + O2 = NAD+ + H2O + glyoxylate + iminodiacetate." [UM-
  • new def: "Catalysis of the reaction: nitrilotriacetate + FMNH2 + O2 = aminodiacetate + FMN + glyoxylate + H2O." [RHEA:31359]
  • added xref type +xref: EC:1.14.14.10 {source="skos:exactMatch"}
  • added xref: KEGG_REACTION:R09798
  • added xref: MetaCyc:RXN-9508
  • added xref: RHEA:31359 {source="skos:exactMatch"}
  • removed is_a: GO:0016646 ! oxidoreductase activity, acting on the CH-NH group of donors, NAD or NADP as acceptor
  • added is_a: GO:0016712 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced flavin or flavoprotein as one donor, and incorporation of one atom of oxygen
  • GO:0102136 '3-epi-6-deoxocathasterone C-23 hydroxylase activity': change parent from oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, NAD(P)H as one donor, and incorporation of one atom of oxygen to oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced flavin or flavoprotein as one donor, and incorporation of one atom of oxygen
  • GO:0052869 arachidonic acid omega-hydroxylase activity:
  • remove EC:1.14.15.3; add RHEA:3975 and MetaCyc:RXN-19677
  • change parent to 'oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, reduced flavin or flavoprotein as one donor, and incorporation of one atom of oxygen'
  • GO:0050183 phosphatidylcholine 12-monooxygenase activity
  • fix def to match RHEA: from def: "Catalysis of the reaction: 1-acyl-2-oleoyl-sn-glycero-3-phosphocholine + H+ + NADH + O2 = 1-acyl-2-[(S)-12-hydroxyoleoyl]-sn-glycero-3-phosphocholine + H2O + NAD+." [RHEA:46360]
    new def: "Catalysis of the reaction: 1-acyl-2-(9Z)-octadecenoyl-sn-glycero-3-phosphocholine + 2 Fe(II)-[cytochrome b5] + 2 H+ + O2 = 1-acyl-2-[(R)-12-hydroxyoleoyl]-sn-glycero-3-phosphocholine + 2 Fe(III)-[cytochrome b5] + H2O." [RHEA:46360]
  • fix parent from GO:0016709 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, NAD(P)H as one donor, and incorporation of one atom of oxygen
    to GO:0016716 ! oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, another compound as one donor, and incorporation of one atom of oxygen

pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Jun 13, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 2, 2024

Obsolete

  • GO:0035410 dihydrotestosterone 17-beta-dehydrogenase activity: represents a specific substrate of GO:0030283 testosterone dehydrogenase [NAD(P)+] activity. 1 UniProt, 1 RGD, will be automatically reannotated,
  • GO:0052740 1-acyl-2-lysophosphatidylserine acylhydrolase activity: represents the same activity as GO:0008970 'phospholipase A1 activity', 0 annotations
  • GO:0102257 1-16:0-2-18:2-phosphatidylcholine sn-1 acylhydrolase activity: represents a specific substrate of GO:0008970 'phospholipase A1 activity', 0 annotations
  • GO:0034321 alcohol O-octanoyltransferase activity: represents a specific substrate of GO:0004026 'alcohol O-acetyltransferase activity'. No xref mappings. 1 EXP by SGD, will be automatically re-annotated.
  • GO:0034319 alcohol O-butanoyltransferase activity: represents a specific substrate of GO:0004026 'alcohol O-acetyltransferase activity'. No xref mappings. 1 EXP by SGD, will be automatically re-annotated.
  • GO:0034322 alcohol O-decanoyltransferase activity: represents a specific substrate of GO:0004026 'alcohol O-acetyltransferase activity'. No xref mappings. 0 annotations
  • GO:0034320 alcohol O-hexanoyltransferase activity:represents a specific substrate of GO:0004026 'alcohol O-acetyltransferase activity'. No xref mappings. 0 annotations
  • GO:0030744 luteolin O-methyltransferase activity: specific form of GO:0102822 flavone 3'-O-methyltransferase activity] (was named quercetin 3'-O-methyltransferase activity; made name more general to align with EC and RHEA)
  • GO:0043431 2-octaprenyl-3-methyl-5-hydroxy-6-methoxy-1,4-benzoquinone methyltransferase activity: represents a specific substrate of 3-demethylubiquinol-n 3-O-methyltransferase activity ; GO:0061542.
  • GO:0103066 4alpha-carboxy-4beta-methyl-5alpha-cholesta-8-en-3beta-ol:NAD(P)+ 3-oxidoreductase (decarboxylating) activity: represents a specific substrate of C-3 sterol dehydrogenase (C-4 sterol decarboxylase) activity ; GO:0000252. 0 annotations
  • GO:0103067 4alpha-carboxy-5alpha-cholesta-8-en-3beta-ol:NAD(P)+ 3-dehydrogenase (decarboxylating) activity: represents a specific substrate of C-3 sterol dehydrogenase (C-4 sterol decarboxylase) activity ; GO:0000252. 0 annotations

pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
pgaudet added a commit that referenced this issue Sep 2, 2024
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 2, 2024

No more errors
#26235

@pgaudet pgaudet closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant