modify about currency #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takamasa-Murano
commented
Aug 20, 2024
| const currencyType = config.getConfig('currency.adServerCurrency'); | ||
| if (typeof currencyType === 'string' && ALLOWED_CURRENCIES.indexOf(currencyType) === -1) { | ||
| utils.logError('Invalid currency type, we support only JPY and USD!'); | ||
| return false; |
There was a problem hiding this comment.
Do you need to add a currency param instead of using the adserverCurrency as you do in your dsp adapter ?
adserverCurrencyの使用で、リクエストしている貨幣種類を返してくれるとのことなので、こちらを使用するように修正
（ref: https://github.com/prebid/Prebid.js/blob/master/modules/dsp_genieeBidAdapter.js#L74 ）
Takamasa-Murano
commented
Aug 20, 2024
| @@ -84,16 +83,18 @@ describe('ssp_genieeBidAdapter', function () { | |||
| }); | |||
|
|
|||
| it('should return true when params.zoneId and params.currency exist and params.currency is JPY or USD', function () { | |||
| config.setConfig({ currency: { adServerCurrency: 'JPY' } }); | |||
There was a problem hiding this comment.
リクエストする貨幣種類のセットのためにconfig.setConfigを使用する形に修正
Takamasa-Murano
commented
Aug 20, 2024
| ]); | ||
| expect(String(request[0].data.ib)).to.have.string('0'); | ||
| expect(String(request[1].data.ib)).to.have.string(''); | ||
| expect(String(request[1].data.ib)).to.have.string('0'); | ||
| expect(String(request[2].data.ib)).to.have.string('0'); |
There was a problem hiding this comment.
検証忘れ
data.ibについては常に0を返す形にしていたので
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
To respond to the point of view from Prebid.js, I modify about
currencyinisBidRequestValidfuction to useconfig.getConfig('currency.adServerCurrency')Other information