feat: process noproxy rules even with MODE_CONFIG_PAC #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please merge this feature? I need this absolutely! :) |
quentinpopp
approved these changes
Feb 3, 2023
|
Thanks for the PR - I'll be fixing this for all modes along with noproxy_hosts support in 0.9.0 so closing this. For now, close to releasing 0.8.4 with some bug fixes so might be a few days to get this out. |
|
This is fixed in v0.9.0 still in development - see branch. Px noproxy now overrides all modes. Appreciate any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PX in MODE_CONFIG_PAC, noproxy rules are ignored.
This commit indicates required changes in order to have the expected behavior.