Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerpc/ppc64: unmask media-libs/libva #37198

Closed
wants to merge 4 commits into from
Closed

Conversation

a17r
Copy link
Member

@a17r a17r commented Jun 17, 2024

No description provided.

@a17r a17r requested a review from thesamesam June 17, 2024 17:02
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @a17r
Areas affected: profiles
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 934215

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 17, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-06-17 17:41 UTC
Newest commit scanned: 1f878ad
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0918ec4394/output.html

@a17r a17r requested a review from arthurzam June 17, 2024 18:34
# Georgy Yakovlev <[email protected]> (2019-02-04)
# Temurin ppc64 build is little-endian only
# so we can use bins.
-dev-java/openjdk-bin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was reported as UnmatchedProfilePackageUnmask, so I assumed it was free to cleanup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rechecked all the stuff, and all those unmasks are "anti mask" for ppc64be, but for those we cleaned up the arches well, so no need for those unmasks.

Thank you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please for now move those masks you drop here to profiles/arch/powerpc/ppc64/64ul/package.mask (meaning for big endian ppc64) until further verification of libva working on big endian.

ppc64le is much stabler and usable than ppc64be.

Copy link
Member Author

@a17r a17r Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems they are already masked on 64ul.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similary, please move those masks to the big endian profile: profiles/arch/powerpc/ppc64/64ul/package.use.mask until further investigation.

@arthurzam
Copy link
Member

Pinged powerpc users (in #gentoo-powerpc IRC) if they know how well libva works on big endian ppc64.

a17r added 4 commits June 17, 2024 21:07
Mask taken from powerpc/ppc64/64le/package.mask, inverted.

Signed-off-by: Andreas Sturmlechner <[email protected]>
Mask taken from powerpc/ppc64/64le/package.use.mask, inverted.

Signed-off-by: Andreas Sturmlechner <[email protected]>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-06-17 19:31 UTC
Newest commit scanned: 545375a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5ea2326401/output.html

@arthurzam
Copy link
Member

@a17r after some checks with powerpc users, libva somewhat works and somewhat not on powerpc64 big-endian. I think this is good enough to simplify the profiles and just unmask it across ppc64 profiles.

@sdhoward
Copy link

we cleaned up the arches well

Prior to this PR, a package was masked in ppc64ul (both endians) and then unmasked in ppc64le. This had the intended effect of masking it only on ppc64 (be).

In this PR, that work was undone. At least one unmask was removed from ppc64le, while the mask remained in ppc64 (be) - https://bugs.gentoo.org/925111#c8

Was the pkgcheck tool reporting UnmatchedProfilePackageUnmask incorrectly? If so, please follow up with a bug.

Also you said that even though a package is not working on ppc64 (be), it can be unmasked. The reasoning is hard to follow.

@thesamesam
Copy link
Member

Was the pkgcheck tool reporting UnmatchedProfilePackageUnmask incorrectly? If so, please follow up with a bug.

I already did at pkgcore/pkgcheck#685 for https://bugs.gentoo.org/918647#c5.

Also you said that even though a package is not working on ppc64 (be), it can be unmasked. The reasoning is hard to follow.

I covered that in the commit message (86238ae).

Anyway, please file a bug for the broken unmasks.

@thesamesam
Copy link
Member

thesamesam commented Jun 26, 2024

I'll just revert it now as matoro asked (now done in 5429444).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants