configurable tmp dir #30
Conversation
chrstnbwnkl
force-pushed
the
cb-update-only
branch
from
5891061
to
0d98a2c
Compare
|
we can run the test once the update only PR is merged and we change the target branch to main :) |
docker-compose.yml
Outdated
| o: bind | ||
| tmp_packages: # do not change any detail of this volume |
There was a problem hiding this comment.
I just copied the volume configuration from the other one for now.
There was a problem hiding this comment.
let's call it just tmp_data, there's no packages
|
hm, I just realize CI is still running on ubuntu 20.04. might wanna change that to ubuntu-latest (either here or at some point). |
| driver: local | ||
| driver_opts: | ||
| type: none | ||
| device: $TMP_DATA_DIR # DATA_DIR is the host directory for the data. It has to be in the environment, e.g. in .env file |
There was a problem hiding this comment.
| device: $TMP_DATA_DIR # DATA_DIR is the host directory for the data. It has to be in the environment, e.g. in .env file | |
| device: $TMP_DATA_DIR # TMP_DATA_DIR is the host directory for the data. It has to be in the environment, e.g. in .env file |
docker-compose.yml
Outdated
| o: bind | ||
| tmp_packages: # do not change any detail of this volume |
There was a problem hiding this comment.
let's call it just tmp_data, there's no packages
|
It might also be good to have a test in place. Current tests are checking whether a package was created and has the right graph packaged, but all from a request's response. I guess it'd be enough to check the path set by the env var? |
was thinking about the other PR 😅 |
End to end testing is not trivial, we don't actually push the jobs in the Arq queue when testing. This would require us to have a distinct test setup with only a small PBF instead of the planet and so on... maybe something for the future. |
…ger into cb-temp-dir
Proposed Changes
This PR separates the directories for created packages and all other files (i.e. planet PBF, graph, etc.).
DATA_DIRrefers to the location where all created packages will be stored whereasTMP_DIRstores the planet PBF, the graph tiles, elevation data, and so on.Migration
Migration should be easy, just move all the files that are not packaged extracts to the new
TMP_DATA_DIRlocation before starting the services.