BGDIINF_SB-1261: Fixed dockerrun target #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dockerrun make target was done to run a local docker image on port 8080. The port 8080 is already used by the BIT proxy on the developper machines and there were not target for building a local image. Now there is a target to build local image that can be started by dockerrun. The default exported port by the local docker image is 5000 and can be changed by an environment variable. This variable needs to be set prior to deployment in order to use another port, but as deployment will be automated it is not an issue to have to set an environment variable before it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dockerrun make target was done to run a local docker image on port
8080. The port 8080 is already used by the BIT proxy on the developper
machines and there were not target for building a local image.
Now there is a target to build local image that can be started by
dockerrun.
The default exported port by the local docker image is 5000 and can be
changed by an environment variable. This variable needs to be set prior
to deployment in order to use another port, but as deployment will be
automated it is not an issue to have to set an environment variable
before it.