Improved and fixed dependencies in makefile #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile dependencies where not correct. For example if a pip requirements file were modified the requirements needed to be manually re-installed. There was also a bug using the lint target when a local python build was done. Because the local python build was inside a normal directory, its content was passed to pylint which then failed. Also the local build for another python version of 3.7 would have not worked due to hard coded python binary to python3.7. Now all dependencies have been corrected, which means that in between two call of make serve if the requirements.txt has been modified, the target make setup is automatically called. The python local build is now done within a hidden directory (.local) which is then not passed to pylint nor to yapf. Also make use of proper make target in the buidlspec.
The make test target depend on the dev requirements (for nose2 installation which is part of the dev tools)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix has been ported from geoadmin/service-qrcode#13.
Makefile dependencies where not correct. For example if a pip requirements
file were modified the requirements needed to be manually re-installed.
There was also a bug using the lint target when a local python build
was done. Because the local python build was inside a normal directory,
its content was passed to pylint which then failed. Also the local build
for another python version of 3.7 would have not worked due to hard
coded python binary to python3.7.
Now all dependencies have been corrected, which means that in between
two call of make serve if the requirements.txt has been modified, the
target make setup is automatically called.
The python local build is now done within a hidden directory (.local)
which is then not passed to pylint nor to yapf.
Also make use of proper make target in the buidlspec.