New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement arrow2 `Array` trait for geometry arrays #112

Closed

kylebarron wants to merge 1 commit into main from kyle/arrow2-array-trait

Member

kylebarron commented Jul 29, 2023 •

edited

Loading

Unsure whether this is wise or not. The arrow2 Array trait can be implemented by external structs. But we don't store a literal arrow2 array object so that we can avoid downcasting overhead. But this means that e.g. debug fails
https://github.com/jorgecarleitao/arrow2/blob/d5c78e7ba45fcebfbafd55a82ba2601ee3ea9617/src/array/mod.rs#L305-L332

Because it's not a builtin arrow2 array.

So I'm thinking it'll probably be better to keep them separate


          implement arrow2 Array for geometry arrays

94dfeff

kylebarron changed the title ~~implement arrow2 Array for geometry arrays~~ implement arrow2 Array trait for geometry arrays

kylebarron closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet