Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert theme change to see how it looks #32

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

asinghvi17
Copy link
Collaborator

I thought the old theme looked cleaner, this will let us see them side by side.

I thought the old theme looked cleaner, this will let us see them side by side.
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for courageous-phoenix-f7cc3c ready!

Name Link
🔨 Latest commit d5fa577
🔍 Latest deploy log https://app.netlify.com/sites/courageous-phoenix-f7cc3c/deploys/66f4352d78373d00088a2a1f
😎 Deploy Preview https://deploy-preview-32--courageous-phoenix-f7cc3c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot temporarily deployed to pull request September 25, 2024 16:18 Inactive
@asinghvi17 asinghvi17 marked this pull request as ready for review September 25, 2024 18:45
@asinghvi17
Copy link
Collaborator Author

Reverting the theme change by consensus on Slack, will open some PRs with more theme options when we have more content!

@asinghvi17 asinghvi17 merged commit 5396b13 into main Sep 25, 2024
6 checks passed
@asinghvi17 asinghvi17 deleted the as/revert_theme branch September 25, 2024 18:46
@Nowosad
Copy link
Member

Nowosad commented Sep 26, 2024

@asinghvi17 my thinking while changing the theme was to make a slight visual difference between the geocompy and geocompjl books. I agree that the second style for less readable. Maybe another option is just to use some other color for the hyperlinks (etc)? What do you think?

@Nowosad Nowosad mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants