Docker build file for sw4 enabled with hdf5 and zfp compression features #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jf-huang I think EXTRA_CXX_FLAGS=-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H should not be used, can you compile without it? |
|
@houjun Thanks for the feedback! Yes you are right, it compiles without the EXTRA_CXX_FLAGS. |
…ILD_TIME to trigger build
houjun
reviewed
Mar 27, 2023
configs/Dockerfile
Outdated
| # build sw4 | ||
| RUN git -c http.sslVerify=false clone https://github.com/geodynamics/sw4.git && \ | ||
| cd sw4/ && git switch developer && rm -r .git/ && \ | ||
| ln -s /usr/lib/x86_64-linux-gnu/libssl.so.1.1 /usr/lib64/libssl.so && \ |
There was a problem hiding this comment.
@jf-huang, I think the latest sw4 doesn't need libssl and libcrypto explicitly, they are needed for libproj and should link automatically. Can you try removing this and the next line to see if sw4 compiles successfully?
There was a problem hiding this comment.
@houjun Thanks for the suggestion, the file is also updated with recent makefile changes. Passed the compilation.
|
@andersp this is ready to be merged. |
|
Hi Houjun,
Not sure how to merge in this PR since it comes from a forked repo, see attachment.
-Anders
From: Houjun Tang ***@***.***>
Date: Monday, March 27, 2023 at 11:20 AM
To: geodynamics/sw4 ***@***.***>
Cc: Petersson, Anders ***@***.***>, Mention ***@***.***>
Subject: Re: [geodynamics/sw4] Docker build file for sw4 enabled with hdf5 and zfp compression features (PR #117)
@andersp<https://urldefense.us/v3/__https:/github.com/andersp__;!!G2kpM7uM-TzIFchu!go9204ynnBbLXPgeNkLiASSNlTePlrrJObV6lkrKJUgRc_fvz9eSQSO9PdGDidLGpXk$> this is ready to be merged.
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https:/github.com/geodynamics/sw4/pull/117*issuecomment-1485639241__;Iw!!G2kpM7uM-TzIFchu!go9204ynnBbLXPgeNkLiASSNlTePlrrJObV6lkrKJUgRc_fvz9eSQSO9PdGD7LcQnLc$>, or unsubscribe<https://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/ACECFB4KETPOVVRX6EKK2CDW6HK5LANCNFSM5LYAFNPA__;!!G2kpM7uM-TzIFchu!go9204ynnBbLXPgeNkLiASSNlTePlrrJObV6lkrKJUgRc_fvz9eSQSO9PdGDTqU2M4c$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@andersp, you can just click the "Merge pull request" button if you can see it on the github pull request page. |
|
That’s the thing. This PR does not show up under pull requests. I can only see it by following the link in the email.
From: Houjun Tang ***@***.***>
Date: Monday, March 27, 2023 at 11:46 AM
To: geodynamics/sw4 ***@***.***>
Cc: Petersson, Anders ***@***.***>, Mention ***@***.***>
Subject: Re: [geodynamics/sw4] Docker build file for sw4 enabled with hdf5 and zfp compression features (PR #117)
@andersp<https://urldefense.us/v3/__https:/github.com/andersp__;!!G2kpM7uM-TzIFchu!i-dv4gsrYDuykO-Evd5_ypAKBd6FfDDVFxstT7F5AnW_uimYuIrYv6RRazdJaYGCo6E$>, you can just click the "Merge pull request" button if you can see it on the github pull request page.
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https:/github.com/geodynamics/sw4/pull/117*issuecomment-1485690316__;Iw!!G2kpM7uM-TzIFchu!i-dv4gsrYDuykO-Evd5_ypAKBd6FfDDVFxstT7F5AnW_uimYuIrYv6RRazdJYLuf4GU$>, or unsubscribe<https://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/ACECFB2GA6JT5EZKXKFVWOTW6HOAJANCNFSM5LYAFNPA__;!!G2kpM7uM-TzIFchu!i-dv4gsrYDuykO-Evd5_ypAKBd6FfDDVFxstT7F5AnW_uimYuIrYv6RRazdJ-xzKmyM$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.