test installer #36
test installer #36
Conversation
|
Oooooh, thank you so much! FWIW, I don't mind little PRs that chunk out the work. Even a PR that tests one little piece of functionality would be big enough to merge in IMO. Let me know when you are comfortable with where this PR is at and we'll go from there. |
- add flag support for installer version - print mix help info when `mix vox.new` is ran without args - add test for vox.new task
Parker-Bartlett
force-pushed
the
test-installer
branch
from
aa30471
to
0017b40
Compare
|
@geolessel I'm all for keeping PRs small 😄 It should be ready to look over, let me know if there's anything I can update. By the way, the last commit is adding the installer tests to CI, I can't validate that it works myself. I should be able to tell once the workflow runs on this PR. |
installer/test/mix_helper.exs
Outdated
| end | ||
|
|
||
| defp random_string(len) do | ||
| len |> :crypto.strong_rand_bytes() |> Base.encode64() |> binary_part(0, len) |
There was a problem hiding this comment.
Simple style pickiness I suppose but for piped logic I prefer one pipe per line. Mind changing it?
| len |> :crypto.strong_rand_bytes() |> Base.encode64() |> binary_part(0, len) | |
| len | |
| |> :crypto.strong_rand_bytes() | |
| |> Base.encode64() | |
| |> binary_part(0, len) |
|
@Parker-Bartlett Getting closer! It looks like we need to 
|
|
@Parker-Bartlett 🤔 and/or make defp deps do
[
{:ex_doc, "~> 0.30.6", only: :dev, runtime: false}
]
end |
|
Fingers crossed this is the one! And thanks for running CI on these 😆 |
related to #31
A starting place for testing the installer. It also adds support for printing the installer version and showing the task's help doc when used without arguments. It mostly follows the testing strategy used in the Phoenix installer.