Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled MapLibre GL JS to v4.4.1 #392

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

naogify
Copy link
Member

@naogify naogify commented Jun 26, 2024

MapLibre GL JS を v4.4.1 にアップデートしました。

合わせて addProtocol の第二引数の型が変更になっておりビルド時にエラーが出たので、pmtiles モジュールをアップデートすることで解決しました。

[tsl] ERROR in /Users/naoppy/geolonia/embed/src/lib/render.ts(14,37)
      TS2345: Argument of type '(params: RequestParameters, callback: ResponseCallback) => Cancelable' is not assignable to parameter of type 'AddProtocolAction'.
  Types of parameters 'callback' and 'abortController' are incompatible.
    Type 'AbortController' is not assignable to type 'ResponseCallback'.
      Type 'AbortController' provides no match for the signature '(error?: Error, data?: any, cacheControl?: string, expires?: string): void'.

参考

@naogify naogify marked this pull request as ready for review July 1, 2024 08:35
@keichan34 keichan34 merged commit 0a8be3b into master Sep 30, 2024
7 checks passed
@keichan34 keichan34 deleted the update-maplibre-gl-js branch October 28, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants