Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

クラスタリングクリック時のズームが効かなくなっていたので修正 #398

Merged
merged 2 commits into from
Oct 25, 2024
Merged

クラスタリングクリック時のズームが効かなくなっていたので修正 #398

merged 2 commits into from
Oct 25, 2024

Conversation

naogify
Copy link
Member

@naogify naogify commented Jul 30, 2024 •
edited by keichan34
Loading

getClusterExpansionZoom が、callback から、promise を使うような変更があり、クラスタリングクリック時のズームが効かなくなっていたので修正しました。

⚠️ Changed the GeoJSONSource's getClusterExpansionZoom, getClusterChildren, getClusterLeaves methods to return a Promise instead of a callback usage (#3421)

Related to maplibre/maplibre-gl-js#3421

Fixes #396

@naogify naogify marked this pull request as draft September 3, 2024 03:02
@naogify naogify marked this pull request as ready for review September 30, 2024 02:06
@naogify naogify marked this pull request as draft September 30, 2024 02:08
@naogify naogify changed the base branch from master to fix-for-loadimage September 30, 2024 08:44
@naogify naogify marked this pull request as ready for review September 30, 2024 08:44
keichan34
keichan34 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました！

@keichan34 keichan34 merged commit e6e66ce into fix-for-loadimage Oct 25, 2024
7 checks passed
@keichan34 keichan34 deleted the fix-cluster-zoom branch October 25, 2024 06:01
@keichan34 keichan34 mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichan34 keichan34 keichan34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naogify @keichan34