Makes sure rotateEnabled() always returns a boolean. (#1455) (patch)

`_rotateEnabled` might not yet be initialized when calling `rotateEnabled`, returning `undefined` in that case. Adopting this pattern from other places such as `layerDragEnabled`.
geoman-io · Feb 15, 2024 · d15ba86 · d15ba86
1 parent 7f388cc
commit d15ba86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cypress/integration/rotation.spec.js b/cypress/integration/rotation.spec.js
@@ -37,6 +37,7 @@ describe('Rotation', () => {
 
     cy.window().then(({ map }) => {
       const layer = map.pm.getGeomanDrawLayers()[0];
+      expect(layer.pm.rotateEnabled()).to.equal(false);
 
       layer.pm.enableRotate();
       expect(layer.pm.rotateEnabled()).to.equal(true);

diff --git a/src/js/Mixins/Rotating.js b/src/js/Mixins/Rotating.js
@@ -222,7 +222,7 @@ const RotateMixin = {
     }
   },
   rotateEnabled() {
-    return this._rotateEnabled;
+    return !!this._rotateEnabled;
   },
   // angle is clockwise (0-360)
   rotateLayer(degrees) {