[Refactor] Extends Circle from CircleMarker (patch) #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TurtIeSocks sorry for the very late replay! I thought it would be the best to make Circle extending CircleMarker instead of having the same code twice. If you have time it would be nice, if can take a look into the code. Together with @codeofsumit I will find another name then |
codeofsumit
reviewed
Jun 4, 2023
codeofsumit
changed the title
codeofsumit
changed the title
# Conflicts: # src/js/Draw/L.PM.Draw.Circle.js # src/js/Draw/L.PM.Draw.CircleMarker.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general the code for
CircleandCircleMarkerwas the same. To reduce the maintainence work, this PR makes that theCircleextends fromCircleMarkerand overwrites only the necessary options and functions.Additionally it is now possible to hide the radius edit-handlers with
editableCircle: falselike for the CircleMarker.And the option of CircleMarker is renamed from
editabletoeditableCircleMarker, with a fallback for older versions.editableSupersede #1216