Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve esbuild bundle script to watch css changes and output sourcemaps #1451

Merged
merged 4 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions bundle.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import * as esbuild from 'esbuild';
import fs from 'fs';

const plugins = [{
name: 'my-plugin',
setup(build) {
let count = 0;
build.onEnd(({ errors, warnings }) => {
count++;
const message = errors.length === 0 && warnings.length === 0
? 'Build completed.'
: `Build completed with ${errors.length} error(s) and ${warnings.length} warning(s).`;
console.log(`[BUILD #${count.toString().padStart(3, '0')}]:`, message); });
},
}];

const buildOptions = {
bundle: true,
entryPoints: ['./src/js/L.PM.js'],
loader: {
'.js': 'jsx',
'.css': 'css',
'.svg': 'dataurl' },
minify: true,
outfile: './dist/leaflet-geoman.js',
//plugins: plugins,
sourcemap: true,
}

const ctx = await esbuild.context({ ...buildOptions, plugins });

if (process.env.DEV) {
await ctx.watch();
console.log('watching...');
const { host, port } = await ctx.serve({
port: 5500,
servedir: '.',
fallback: "./index.html"
});
console.log(`Serving app at ${host}:${port}.`);
} else {
await ctx.rebuild();
ctx.dispose();
fs.copyFileSync('leaflet-geoman.d.ts', './dist/leaflet-geoman.d.ts');
fs.copyFileSync('./dist/leaflet-geoman.js', './dist/leaflet-geoman.min.js');
}
39 changes: 0 additions & 39 deletions bundle.ts

This file was deleted.

4 changes: 2 additions & 2 deletions demo/customcontrols.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ <h2>Custom Controls in the Toolbar</h2>
</article>
</div>
<script src="https://unpkg.com/leaflet@latest/dist/leaflet.js"></script>
<script src="../dist/leaflet-geoman.min.js"></script>
<script src="../dist/leaflet-geoman.js"></script>
<!-- You can change from the local source to the cdn: -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.min.js"></script> -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js"></script> -->
<script src="customcontrols.js"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions demo/events.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ <h2>Overview of the available events (Console)</h2>
</article>
</div>
<script src="https://unpkg.com/leaflet@latest/dist/leaflet.js"></script>
<script src="../dist/leaflet-geoman.min.js"></script>
<script src="../dist/leaflet-geoman.js"></script>
<!-- You can change from the local source to the cdn: -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.min.js"></script> -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js"></script> -->
<script src="events.js"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions demo/index-canvas.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ <h2>Editing A Layer Group</h2>
</article>
</div>
<script src="https://unpkg.com/leaflet@latest/dist/leaflet.js"></script>
<script src="../dist/leaflet-geoman.min.js"></script>
<script src="../dist/leaflet-geoman.js"></script>
<!-- You can change from the local source to the cdn: -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.min.js"></script> -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js"></script> -->
<script src="demo-canvas.js"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ <h2>Editing A Layer Group</h2>
</article>
</div>
<script src="https://unpkg.com/leaflet@latest/dist/leaflet.js"></script>
<script src="../dist/leaflet-geoman.min.js"></script>
<script src="../dist/leaflet-geoman.js"></script>
<!-- You can change from the local source to the cdn: -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.min.js"></script> -->
<!-- <script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js"></script> -->
<script src="demo.js"></script>
</body>
</html>
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
<div id="map"></div>
</div>
<!--
<script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.min.js"></script>
<script src="https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js"></script>

-->
<script src="dist/leaflet-geoman.min.js"></script>
<script src="dist/leaflet-geoman.js"></script>
</body>
</html>
28 changes: 28 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"files": [
"dist"
],
"main": "dist/leaflet-geoman.min.js",
"main": "dist/leaflet-geoman.js",
"types": "dist/leaflet-geoman.d.ts",
"dependencies": {
"@turf/boolean-contains": "^6.5.0",
Expand All @@ -30,6 +30,7 @@
},
"devDependencies": {
"@types/leaflet": "^1.7.9",
"cross-env": "^7.0.3",
"cypress": "6.9.1",
"cypress-wait-until": "1.7.1",
"esbuild": "^0.20.0",
Expand All @@ -50,8 +51,8 @@
},
"scripts": {
"start": "npm run dev",
"dev": "esbuild ./src/js/L.PM.js --bundle --watch --loader:.svg=dataurl --outfile=dist/leaflet-geoman.min.js",
"build": "ts-node bundle.ts",
"dev": "cross-env DEV=true ts-node bundle.mjs",
"build": "ts-node bundle.mjs",
"test": "cypress run",
"cypress": "cypress open",
"prepare": "npm run build && husky install",
Expand Down
2 changes: 1 addition & 1 deletion src/assets/translations/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ export default {
fi,
ko,
ky,
};
};
4 changes: 2 additions & 2 deletions src/js/Mixins/Keyboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ const createKeyboardMixins = () => ({
map.once('unload', this._unbindKeyListenerEvents, this);
},
_unbindKeyListenerEvents() {
L.DomEvent.off(document, 'keydown keyup', this._onKeyListener, this);
L.DomEvent.off(window, 'blur', this._onBlur, this);
L.DomEvent.off(document, 'keydown keyup', this._onKeyListener, this);
L.DomEvent.off(window, 'blur', this._onBlur, this);
},
_onKeyListener(e) {
let focusOn = 'document';
Expand Down
Loading