The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: redundant clone --> halo2_proofs/src/protostar/verifier.rs:688:28 | 688 | v_acc0.fold(&v_acc1.clone(), &pk, &mut v_transcript); | ^^^^^^^^ help: remove this | note: cloned value is neither consumed nor mutated --> halo2_proofs/src/protostar/verifier.rs:688:22 | 688 | v_acc0.fold(&v_acc1.clone(), &pk, &mut v_transcript); | ^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `-W clippy::redundant-clone` implied by `-W clippy::all`

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> halo2_proofs/src/protostar/row_evaluator/interpolate.rs:59:29 | 59 | .zip(denoms.into_iter()) | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`

warning: field `num_selector_rows` is never read --> halo2_proofs/src/protostar/keygen.rs:39:5 | 25 | pub struct ProvingKey<C: CurveAffine> { | ---------- field in this struct ... 39 | num_selector_rows: Vec<usize>, | ^^^^^^^^^^^^^^^^^ | = note: `ProvingKey` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: function `lagrange_from_vec` is never used --> halo2_proofs/src/poly.rs:91:15 | 91 | pub(crate) fn lagrange_from_vec<F: ff::Field>(values: Vec<F>) -> Polynomial<F, LagrangeCoeff> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sinsemilla.rs:200:30 | 200 | assert!(num_words <= piece_max_num_words as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: function `test_prover` is never used --> halo2_proofs/examples/folding.rs:281:4 | 281 | fn test_prover<C: CurveAffine, const W: usize, const H: usize>( | ^^^^^^^^^^^

warning: function `test_mock_prover` is never used --> halo2_proofs/examples/folding.rs:254:4 | 254 | fn test_mock_prover<F: Ord + FromUniformBytes<64>, const W: usize, const H: usize>( | ^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused import: `protostar::verifier::VerifierAccumulator` --> halo2_proofs/examples/folding.rs:19:5 | 19 | protostar::verifier::VerifierAccumulator, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/util.rs:113:31 | 113 | let carry = sum.map(|sum| (sum >> 32) as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57 | 180 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/benches/commit_zk.rs:29:46 | 29 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..n_chunks) | ______________________________________________^ 30 | | .into_iter() | |____________________^ help: consider removing `.into_iter()`: `(0..n_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57 | 264 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34 | 56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34 | 50 | + SUBREGION_3_WORD * (word_idx - 49) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47 | 43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65 | 786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)), | ^^^^^^^^^^^^ help: try: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13 | 114 | (idx as usize) * SUBREGION_MAIN_WORD | ^^^^^^^^^^^^^^ help: try: `idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25 | 51 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25 | 25 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:513:77 | 513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:473:73 | 473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:447:62 | 447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42 | 397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37 | 392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68 | 375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/poseidon.rs:138:25 | 138 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:147:35 | 147 | let mut proof_fs = File::open(&proof_path).expect("couldn't load sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:143:37 | 143 | let mut file = File::create(&proof_path).expect("Failed to create sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:131:19 | 131 | if File::open(&proof_path).is_err() { | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:104:32 | 104 | let params_fs = File::open(&params_path).expect("couldn't load sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:98:37 | 98 | let mut file = File::create(&params_path).expect("Failed to create sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:93:19 | 93 | if File::open(&params_path).is_err() { | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sinsemilla.rs:200:30 | 200 | assert!(num_words <= piece_max_num_words as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/util.rs:113:31 | 113 | let carry = sum.map(|sum| (sum >> 32) as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57 | 180 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57 | 264 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34 | 56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34 | 50 | + SUBREGION_3_WORD * (word_idx - 49) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47 | 43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65 | 786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)), | ^^^^^^^^^^^^ help: try: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13 | 114 | (idx as usize) * SUBREGION_MAIN_WORD | ^^^^^^^^^^^^^^ help: try: `idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25 | 51 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25 | 25 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:513:77 | 513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:473:73 | 473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:447:62 | 447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42 | 397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37 | 392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68 | 375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> halo2_proofs/src/protostar/row_evaluator/interpolate.rs:59:29 | 59 | .zip(denoms.into_iter()) | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`

warning: field `num_selector_rows` is never read --> halo2_proofs/src/protostar/keygen.rs:39:5 | 25 | pub struct ProvingKey<C: CurveAffine> { | ---------- field in this struct ... 39 | num_selector_rows: Vec<usize>, | ^^^^^^^^^^^^^^^^^ | = note: `ProvingKey` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: function `lagrange_from_vec` is never used --> halo2_proofs/src/poly.rs:91:15 | 91 | pub(crate) fn lagrange_from_vec<F: ff::Field>(values: Vec<F>) -> Polynomial<F, LagrangeCoeff> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

function `lagrange_from_vec` is never used

field `num_selector_rows` is never read

`halo2_proofs` (lib) generated 2 warnings

unused import: `protostar::verifier::VerifierAccumulator`

function `test_mock_prover` is never used

function `test_prover` is never used

`halo2_proofs` (example "folding") generated 3 warnings (run `cargo fix --example "folding"` to apply 1 suggestion)

`halo2_proofs` (lib test) generated 2 warnings (2 duplicates)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

function `lagrange_from_vec` is never used

field `num_selector_rows` is never read

`halo2_proofs` (lib) generated 2 warnings

unused import: `protostar::verifier::VerifierAccumulator`

function `test_mock_prover` is never used

function `test_prover` is never used

`halo2_proofs` (example "folding") generated 3 warnings (run `cargo fix --example "folding"` to apply 1 suggestion)

`halo2_proofs` (lib test) generated 2 warnings (2 duplicates)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

function `lagrange_from_vec` is never used

field `num_selector_rows` is never read

`halo2_proofs` (lib) generated 2 warnings

unused import: `protostar::verifier::VerifierAccumulator`

function `test_mock_prover` is never used

function `test_prover` is never used

`halo2_proofs` (example "folding") generated 3 warnings (run `cargo fix --example "folding"` to apply 1 suggestion)