Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect translation in map data interface when hover over icon. #8143

Closed
ianwallen opened this issue Jun 4, 2024 · 2 comments · Fixed by #8146
Closed

Incorrect translation in map data interface when hover over icon. #8143

ianwallen opened this issue Jun 4, 2024 · 2 comments · Fixed by #8146
Assignees
@fxprunayre
Labels
bug
Milestone
4.4.5

Comments

@ianwallen
Copy link
Contributor

Describe the bug
Incorrect translation in map interface.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure using English UI

  2. Using Hydrological Basins in Africa (Sample record, please remove!) (da165110-88fd-11da-a88f-000d939bc5d8) as a sample ISO 19139 record. Select
    image

  3. Click on a region on the map
    image

We can see that there is data for that region.
4. Go to far left and hover over the following icon. The translation is incorrect.
image

Expected behavior
Expecting text to be in English.

Desktop (please complete the following information):

  • Browser: Edge
  • GeoNetwork Version 4.4.5-snapshot
@ianwallen ianwallen added the bug label Jun 4, 2024
@josegar74
Copy link
Member

@ianwallen I guess probably it is related to this:

core-geonetwork/web-ui/src/main/resources/catalog/components/viewer/gfi/FeaturesTable.js

Line 222 in 5f448a5

// locale: getBsTableLang()

I don't know why is commented.

@josegar74
Copy link
Member

Uncommenting the code looks working:

tooltip-english

It was changed in 2c4f76b, @fxprunayre do you remember the reason?

@fxprunayre fxprunayre self-assigned this Jun 4, 2024
@fxprunayre fxprunayre added this to the 4.4.5 milestone Jun 4, 2024
fxprunayre added a commit that referenced this issue Jun 4, 2024
@fxprunayre
Map / Feature table / Missing translation
c46a1a4 
Fixes #8143
@fxprunayre fxprunayre mentioned this issue Jun 4, 2024
Merged
10 tasks
fxprunayre added a commit that referenced this issue Jun 5, 2024
@fxprunayre
Map / Feature table / Missing translation
e3b7e35 
Fixes #8143
geonetworkbuild pushed a commit that referenced this issue Jun 5, 2024
@fxprunayre @github-actions
Map / Feature table / Missing translation
64a6f0f 
Fixes #8143
ianwallen pushed a commit that referenced this issue Jun 5, 2024
@geonetworkbuild @fxprunayre
Map / Feature table / Missing translation (#8148)
1a1c2b2 
Fixes #8143

Co-authored-by: François Prunayre <[email protected]>
fxprunayre added a commit to SPW-DIG/metawal-core-geonetwork that referenced this issue Jul 18, 2024
@fxprunayre
Map / Feature table / Missing translation
ff805fe 
Fixes geonetwork#8143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxprunayre fxprunayre

Labels
bug
Projects
None yet
Milestone
4.4.5
Development

Successfully merging a pull request may close this issue.

Map / Feature table / Missing translation geonetwork/core-geonetwork
3 participants
@josegar74 @fxprunayre @ianwallen