Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyling of GeoNetwork #1867

Closed
wants to merge 53 commits into from
Closed

Conversation

MichelGabriel
Copy link
Contributor

Introduction

The main goal of the restyling was to make the user interface more consistent throughout the application and make the homepage more 'attractive'.

The following changes were made to achieve this:

  • restrict the width of the application
  • add more whitespace in the search results
  • reduce the amount of icons used
  • add a full background image (downloaded from Unsplash)
  • align the elements
  • 3 views for the lists on the homepage
  • fixed toolbar
  • repositioned the icons for the records on the ‘contribute’ page

The styling is kept minimal in order to serve as a ‘template’ for future implementations.

Screenshot of the ‘new’ homepage
gn_home

What still needs to be done:

  • optimise the background image
  • the admin pages
  • add micro-interactions
  • ...

More screenshots

Search page
gn_search

Contribute page
gn_contribute

- add different list types
- add toggle list type buttons
- add footer blocks
- fixed header
- restyle 'browse by resources' and 'browse by topics'

Add new less files: first restructuring of styles
# Conflicts:
#	web-ui/src/main/resources/catalog/components/search/resultsview/partials/viewtemplates/grid.html
#	web-ui/src/main/resources/catalog/views/default/less/gn_search_default.less
#	web-ui/src/main/resources/catalog/views/default/templates/home.html
#	web-ui/src/main/resources/catalog/views/default/templates/index.html
- login
- register
- editor
- detail view
@pvgenuchten
Copy link

Looks good Michel, looking forward to hear opinions. Would it make sense to squash some of the commits before merging?

Would be interesting (next iteration) to allow to replace the background image by an uploaded alternative in the admin ui.

@josegar74
Copy link
Member

josegar74 commented Feb 2, 2017

@fgravin @fxprunayre if you hace time, please check for feedback and to verify if can be any issue with #1848

@fxprunayre fxprunayre modified the milestone: 3.4.0 Feb 9, 2017
@fxprunayre
Copy link
Member

After some testing (and a merge with current develop https://github.com/fxprunayre/core-geonetwork/tree/MichelGabriel-develop), here is some comments:

Some elements were removed/changed from the UI and it may be relevant to have the capability to turn them on or off depending on user needs/preferences (I think):

image

Issues (maybe related to the merge):

  • Admin looks squeezed ? probably depends on screen and container fluid/fixed.

image

  • Search results / Click on keyword open record instead of filtering on that keyword
  • Editor / Button of same type used to be vertically aligned

image

  • Harvester / Can't see bottom of dropdown

image

  • Background image displayed in selection div

image

Some stuff I like:

  • facet truncated by ellipsis (instead of number of char)
  • black/white thumbnail in grid mode

Some questions:

image

  • Editor / We had quite some discussion with Max and others to try to avoid to overload too much advanced form with borders and big legends ?

image

image

  • 1.4Mo for a background image is a bit big; adding choices for that would be good ;)

That's it for now on my side. Maybe we should try to organize a mini-codesprint to finalize that; adding config where needed so that everyone can configure its UI (with the easy config made in #1848) and improving the minor missing items.

👍 @MichelGabriel

… into develop-remarks

# Conflicts:
#	web-ui/src/main/resources/catalog/components/search/resultsview/partials/viewtemplates/grid.html
#	web-ui/src/main/resources/catalog/templates/top-toolbar.html
#	web-ui/src/main/resources/catalog/views/default/directives/partials/linksbtn.html
#	web-ui/src/main/resources/catalog/views/default/templates/index.html
#	web-ui/src/main/resources/catalog/views/default/templates/recordView.html
#	web-ui/src/main/resources/catalog/views/default/templates/results.html
#	web-ui/src/main/resources/catalog/views/default/templates/searchForm.html
The label is hidden when the screen gets smaller
… into develop

# Conflicts:
#	web-ui/src/main/resources/catalog/components/search/resultsview/partials/viewtemplates/grid.html
#	web-ui/src/main/resources/catalog/templates/top-toolbar.html
#	web-ui/src/main/resources/catalog/views/default/directives/partials/linksbtn.html
#	web-ui/src/main/resources/catalog/views/default/templates/index.html
#	web-ui/src/main/resources/catalog/views/default/templates/recordView.html
#	web-ui/src/main/resources/catalog/views/default/templates/results.html
#	web-ui/src/main/resources/catalog/views/default/templates/searchForm.html
# Conflicts:
#	web-ui/src/main/resources/catalog/components/search/resultsview/partials/viewtemplates/grid.html
#	web-ui/src/main/resources/catalog/templates/admin/harvest/harvest-settings.html
#	web-ui/src/main/resources/catalog/templates/top-toolbar.html
#	web-ui/src/main/resources/catalog/views/default/directives/partials/linksbtn.html
#	web-ui/src/main/resources/catalog/views/default/templates/index.html
#	web-ui/src/main/resources/catalog/views/default/templates/recordView.html
#	web-ui/src/main/resources/catalog/views/default/templates/results.html
#	web-ui/src/main/resources/catalog/views/default/templates/searchForm.html
… into develop

# Conflicts:
#	web-ui/src/main/resources/catalog/components/search/resultsview/partials/viewtemplates/grid.html
#	web-ui/src/main/resources/catalog/views/default/less/gn_search_default.less
#	web-ui/src/main/resources/catalog/views/default/templates/footer.html
#	web-ui/src/main/resources/catalog/views/default/templates/index.html
#	web-ui/src/main/resources/catalog/views/default/templates/results.html
@fgravin
Copy link
Member

fgravin commented May 29, 2017

I don't really approve this merge at this stage.
We made a lot of feedbacks, are they part of this PR ?

Also, we have many customers that have order the 3.2.x UI with little changes, will be hard to maintain them on develop with such of a change.

Could we discuss about this at Bolsena ?
Slightly too fast merge for me.

@josegar74
Copy link
Member

I understand your concerns @fgravin.

I think a good way to go can be to add this work as a separate view, so users can select which view want to use. That way will be less traumatic for users having customisations based in the default view. But to discuss.

@MichelGabriel MichelGabriel deleted the develop branch August 24, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants