Spring mvc #366
Closed
Spring mvc #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request to synch with geonetwork/core-geonetwork repository
Update to master
…s (for groups list/edit)
… into spring-mvc Conflicts: core/src/main/java/org/fao/geonet/kernel/setting/SettingManager.java core/src/main/resources/config-spring-geonetwork.xml domain/src/main/java/org/fao/geonet/domain/GeonetEntity.java domain/src/main/java/org/fao/geonet/domain/StatusValue.java pom.xml web/pom.xml web/src/main/webResources/WEB-INF/web.xml web/src/main/webapp/WEB-INF/classes/JZKitConfig.xml web/src/main/webapp/WEB-INF/config-security/config-security-mapping.xml web/src/main/webapp/WEB-INF/config-spring-geonetwork.xml
ghost
assigned 
|
|
||
| @Override | ||
| public boolean getValueAsBool(String key) { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Why are these left as not implemented? I think they should either be removed from the API or implemented. It seems like a 1/2 finished job.
There was a problem hiding this comment.
I didn't need it for the example service. The idea is to implement them "on the run" when we need them. Some of them may be a bit deprecated, I think, with the new way of saving settings on the database.
|
Very exciting. I was only this yesterday wondering what the status was on this work. I will give this a +1 once my comments are answered. |
… into spring-mvc Conflicts: common/src/main/java/org/fao/geonet/utils/GeonetHttpRequestFactory.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/geonetwork/core-geonetwork/wiki/Spring-MVC