INSPIRE Validation / Add support to validate using GetRecordById url #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current validation mechanism always upload the record first. Default mode is unchanged. Add a mode parameter to the API (on one record or on a selection) to define the encoding of the record to use: * By default, ISO19139 are used as is and others like ISO19115-3 are converted to ISO19139 if a formatter is available. * If mode = csw, a GetRecordById request pointing to the main portal is used. * If mode = any portal id, then a GetRecordById request is used on this portal. CSW entry point which may define custom CSW post processing. See geonetwork#4493. Add also an API operation to clear current validation status.
josegar74
reviewed
Dec 1, 2020
services/src/main/java/org/fao/geonet/api/processing/MInspireEtfValidateProcess.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/fao/geonet/api/records/InspireValidationApi.java
Outdated
Show resolved
Hide resolved
| Log.error(Log.SERVICE, "Service unavailable.", ex); | ||
| throw ex; | ||
| } | ||
| } finally { |
| @@ -44,7 +44,12 @@ | |||
| class="fa fa-chevron-right"/> | |||
|
|
|||
| <span>{{key}}</span> | |||
| </a> | |||
| </a> | |||
| <!-- | |||
There was a problem hiding this comment.
I understand for now requires to update the UI to use the mode attribute? Would be good after merging the pull request to create an issue to improve this using a setting in a future pull request.
There was a problem hiding this comment.
Yep we have been discussing it with users and we don't really know what should be configurable and how. If using CSW, then record as to be public and if using a portal endpoint, then the record has to be published in that portal filter. So it adds some constraints that it can be hard to figure out by the end user. So upload is easier from that point of view. But yes the config can be added later on.
josegar74
approved these changes
Dec 1, 2020
fxprunayre
added a commit
that referenced
this pull request
Aug 3, 2021
More and more often, end user define a custom INSPIRE portal for being harvested by INSPIRE geoportal. The INSPIRE portal first filter records in the scope of the Directive and may also define post processing to adapt record encoding to INSPIRE rules (see. CSW post processing #4493). If the nodeid parameter is not set, then the record XML is sent to the validator for validation. If defined, then the GetRecordById URL of the record in this node is sent to the validator which retrieve the XML (see #5227). Also add error message in case of validator return an empty token.
fxprunayre
added a commit
that referenced
this pull request
Aug 5, 2021
More and more often, end user define a custom INSPIRE portal for being harvested by INSPIRE geoportal. The INSPIRE portal first filter records in the scope of the Directive and may also define post processing to adapt record encoding to INSPIRE rules (see. CSW post processing #4493). If the nodeid parameter is not set, then the record XML is sent to the validator for validation. If defined, then the GetRecordById URL of the record in this node is sent to the validator which retrieve the XML (see #5227). Also add error message in case of validator return an empty token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current validation mechanism always upload the record first. Default mode is unchanged.
Add a mode parameter to the API (on one record or on a selection) to define the encoding of the record to use:
CSW entry point which may define custom CSW post processing. See #4493.
When using CSW mode, the record has to be publicly accessible for the validator to retrieve it.
Add also an API operation to clear current validation status.