Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record view / Lineage & Quality section improvements #7180

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Record view / Lineage & Quality section improvements #7180

merged 4 commits into from
Aug 30, 2023

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Jun 22, 2023 •
edited
Loading

Process steps

Each steps are described and processing organisations are listed on the right side:

image

Individual names are displayed if any for each steps:

image

Quality measures

image

@fxprunayre fxprunayre added this to the 4.2.5 milestone Jun 22, 2023
@fxprunayre fxprunayre modified the milestones: 4.2.5, 4.2.6 Jul 5, 2023
@fxprunayre fxprunayre changed the title Record view / Lineage / Add process steps. Record view / Lineage & Quality section improvements Jul 13, 2023
@fxprunayre fxprunayre marked this pull request as ready for review July 13, 2023 13:46
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

CMath04 pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request Aug 2, 2023
@fxprunayre @joachimnielandt
Merged PR 25115: 1.0.3 - Standard / ISO19110 / Add cardinality.
d984bdb 
# Standard / ISO19110 / Add cardinality.

In ISO19139, `gfc:cardinality` is a multiplicity element with
lower/upper properties. In ISO19115-3, cardinality is a
`CharacterString`.

Store it as text in the index with `lower..upper` value for ISO19139.

Display cardinality next to the type.

![image.png](https://agiv.visualstudio.com/dc849554-199a-495a-86b3-2669ea01f14c/_apis/git/repositories/0a154993-bcec-4021-98e4-034a6161db36/pullRequests/25115/attachments/image.png)

https://agiv.visualstudio.com/Metadata/_workitems/edit/176988/
geonetwork#7182

# Process steps

![image (2).png](https://agiv.visualstudio.com/dc849554-199a-495a-86b3-2669ea01f14c/_apis/git/repositories/0a154993-bcec-4021-98e4-034a6161db36/pullRequests/25115/attachments/image%20%282%29.png)

geonetwork#7180
https://agiv.visualstudio.com/Metadata/_workitems/edit/170397/

Related work items: #170397, #176988
@fxprunayre
Copy link
Member Author

A good example for testing https://metadata.vlaanderen.be/srv/dut/catalog.search#/metadata/392f870b-f770-44a5-86b7-48b9fefd02b5

MichelGabriel
MichelGabriel approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good. Thanks!

@fxprunayre fxprunayre merged commit 9008874 into main Aug 30, 2023
@fxprunayre fxprunayre deleted the 425-processsteps branch August 30, 2023 09:24
fxprunayre added a commit that referenced this pull request Feb 14, 2024
@fxprunayre
Standard / ISO19115-3 / Quality report / Index descriptive results
ac26f85 
ISO19115-3 adds possibility to provide descriptive results (and not only conformance and quantitative results). Properly index them in order to render them in measure table in record view (#7180)

```xml
<mdb:dataQualityInfo>
      <mdq:DQ_DataQuality>
         <mdq:scope>
            <mcc:MD_Scope>
               <mcc:level>
                  <mcc:MD_ScopeCode codeList="http://standards.iso.org/iso/19115/resources/Codelists/cat/codelists.xml#MD_ScopeCode"
                                    codeListValue="dataset"/>
               </mcc:level>
            </mcc:MD_Scope>
         </mdq:scope>
         <mdq:report>
            <mdq:DQ_QuantitativeAttributeAccuracy>
               <mdq:measure>
                  <mdq:DQ_MeasureReference>
                     <mdq:nameOfMeasure>
                        <gco:CharacterString>Accuracy - overall</gco:CharacterString>
                     </mdq:nameOfMeasure>
                     <mdq:measureDescription>
                        <gco:CharacterString>Assessment of accuracy, linked to a certain Data Set or domain, which is summarising the various components into one single measure.

This metadata element is used to describe the main sources of random and systematic error in the statistical outputs, and provide a summary assessment of all errors with special focus on the impact on key estimates. The bias assessment can be in quantitative or qualitative terms, or both. It should reflect the producer's best current understanding (sign and order of magnitude) including actions taken to reduce bias. Revision aspects should also be included here if considered relevant.</gco:CharacterString>
                     </mdq:measureDescription>
                  </mdq:DQ_MeasureReference>
               </mdq:measure>
               <mdq:result>
                  <mdq:DQ_DescriptiveResult>
                     <mdq:statement>
                        <gco:CharacterString>-text-</gco:CharacterString>
                     </mdq:statement>
                  </mdq:DQ_DescriptiveResult>
               </mdq:result>
               <mdq:result>
                  <mdq:DQ_QuantitativeResult>
                     <mdq:value>
                        <gco:Record>1111</gco:Record>
                     </mdq:value>
                  </mdq:DQ_QuantitativeResult>
               </mdq:result>
            </mdq:DQ_QuantitativeAttributeAccuracy>
         </mdq:report>
      </mdq:DQ_DataQuality>
  </mdb:dataQualityInfo>
```
@fxprunayre fxprunayre mentioned this pull request Feb 14, 2024
Merged
10 tasks
fxprunayre added a commit that referenced this pull request Feb 21, 2024
@fxprunayre
Standard / ISO19115-3 / Quality report / Index descriptive results
95ceba8 
ISO19115-3 adds possibility to provide descriptive results (and not only conformance and quantitative results). Properly index them in order to render them in measure table in record view (#7180)

```xml
<mdb:dataQualityInfo>
      <mdq:DQ_DataQuality>
         <mdq:scope>
            <mcc:MD_Scope>
               <mcc:level>
                  <mcc:MD_ScopeCode codeList="http://standards.iso.org/iso/19115/resources/Codelists/cat/codelists.xml#MD_ScopeCode"
                                    codeListValue="dataset"/>
               </mcc:level>
            </mcc:MD_Scope>
         </mdq:scope>
         <mdq:report>
            <mdq:DQ_QuantitativeAttributeAccuracy>
               <mdq:measure>
                  <mdq:DQ_MeasureReference>
                     <mdq:nameOfMeasure>
                        <gco:CharacterString>Accuracy - overall</gco:CharacterString>
                     </mdq:nameOfMeasure>
                     <mdq:measureDescription>
                        <gco:CharacterString>Assessment of accuracy, linked to a certain Data Set or domain, which is summarising the various components into one single measure.

This metadata element is used to describe the main sources of random and systematic error in the statistical outputs, and provide a summary assessment of all errors with special focus on the impact on key estimates. The bias assessment can be in quantitative or qualitative terms, or both. It should reflect the producer's best current understanding (sign and order of magnitude) including actions taken to reduce bias. Revision aspects should also be included here if considered relevant.</gco:CharacterString>
                     </mdq:measureDescription>
                  </mdq:DQ_MeasureReference>
               </mdq:measure>
               <mdq:result>
                  <mdq:DQ_DescriptiveResult>
                     <mdq:statement>
                        <gco:CharacterString>-text-</gco:CharacterString>
                     </mdq:statement>
                  </mdq:DQ_DescriptiveResult>
               </mdq:result>
               <mdq:result>
                  <mdq:DQ_QuantitativeResult>
                     <mdq:value>
                        <gco:Record>1111</gco:Record>
                     </mdq:value>
                  </mdq:DQ_QuantitativeResult>
               </mdq:result>
            </mdq:DQ_QuantitativeAttributeAccuracy>
         </mdq:report>
      </mdq:DQ_DataQuality>
  </mdb:dataQualityInfo>
```
fxprunayre added a commit that referenced this pull request Aug 12, 2024
@fxprunayre
Standard / ISO19139 / i18n / Missing french translation
ab8a6b8 
On application startup, the translation pack may report an error like the following

```
org.fao.geonet.api.exception.ResourceNotFoundException
        at org.fao.geonet.api.standards.StandardsUtils.getCodelistOrLabel(StandardsUtils.java:72)
        at org.fao.geonet.api.standards.StandardsUtils.getLabel(StandardsUtils.java:55)
        at org.fao.geonet.api.tools.i18n.TranslationPackBuilder.getStandardLabel(TranslationPackBuilder.java:217)
```
due to a missing french translation for element `DQ_EvaluationMethodTypeCode`

Follow up of #7180
@fxprunayre fxprunayre mentioned this pull request Aug 12, 2024
Merged
10 tasks
josegar74 pushed a commit that referenced this pull request Aug 22, 2024
@fxprunayre
Standard / ISO19139 / i18n / Missing french translation (#8298)
0331328 
On application startup, the translation pack may report an error like the following

```
org.fao.geonet.api.exception.ResourceNotFoundException
        at org.fao.geonet.api.standards.StandardsUtils.getCodelistOrLabel(StandardsUtils.java:72)
        at org.fao.geonet.api.standards.StandardsUtils.getLabel(StandardsUtils.java:55)
        at org.fao.geonet.api.tools.i18n.TranslationPackBuilder.getStandardLabel(TranslationPackBuilder.java:217)
```
due to a missing french translation for element `DQ_EvaluationMethodTypeCode`

Follow up of #7180
geonetworkbuild pushed a commit that referenced this pull request Aug 22, 2024
@fxprunayre @github-actions
Standard / ISO19139 / i18n / Missing french translation
d2b08fa 
On application startup, the translation pack may report an error like the following

```
org.fao.geonet.api.exception.ResourceNotFoundException
        at org.fao.geonet.api.standards.StandardsUtils.getCodelistOrLabel(StandardsUtils.java:72)
        at org.fao.geonet.api.standards.StandardsUtils.getLabel(StandardsUtils.java:55)
        at org.fao.geonet.api.tools.i18n.TranslationPackBuilder.getStandardLabel(TranslationPackBuilder.java:217)
```
due to a missing french translation for element `DQ_EvaluationMethodTypeCode`

Follow up of #7180
josegar74 pushed a commit that referenced this pull request Aug 22, 2024
@geonetworkbuild @fxprunayre
Standard / ISO19139 / i18n / Missing french translation (#8306)
22f712f 
On application startup, the translation pack may report an error like the following

```
org.fao.geonet.api.exception.ResourceNotFoundException
        at org.fao.geonet.api.standards.StandardsUtils.getCodelistOrLabel(StandardsUtils.java:72)
        at org.fao.geonet.api.standards.StandardsUtils.getLabel(StandardsUtils.java:55)
        at org.fao.geonet.api.tools.i18n.TranslationPackBuilder.getStandardLabel(TranslationPackBuilder.java:217)
```
due to a missing french translation for element `DQ_EvaluationMethodTypeCode`

Follow up of #7180

Co-authored-by: François Prunayre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelGabriel MichelGabriel MichelGabriel approved these changes

@joachimnielandt joachimnielandt Awaiting requested review from joachimnielandt

@josegar74 josegar74 Awaiting requested review from josegar74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@fxprunayre @MichelGabriel