-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend http proxy to support urls with a duplicated parameter with different values #7456
Extend http proxy to support urls with a duplicated parameter with different values #7456
Conversation
Added a PR with the change to the proxy library mitre/HTTP-Proxy-Servlet#243. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
7b67e82
to
8db06b1
Compare
Extend URITemplateProxyServlet to support urls with a duplicated parameter with different values, like: param1=value1¶m1=value2¶m1=value3 Fix wrong init parameter name
b00cd29
to
7198ba7
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-7456-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 7198ba760b8aab44d1c2141b2e707bc464c73f7f
# Push it to GitHub
git push --set-upstream origin backport-7456-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.x Then, create a pull request where the |
Extend URITemplateProxyServlet to support urls with a duplicated parameter with different values, like: param1=value1¶m1=value2¶m1=value3 Fix wrong init parameter name
Extend URITemplateProxyServlet to support urls with a duplicated parameter with different values, like: param1=value1¶m1=value2¶m1=value3 Fix wrong init parameter name Backport of #7456.
Co-authored-by: Jose García <[email protected]>
Currently the http proxy doesn't support to send a parameter repeated in the url with different values. This causes Kibana when proxied to fail some requests like the following :
http://localhost:8080/geonetwork/dashboards/api/index_patterns/_fields_for_wildcard?pattern=gn-records&meta_fields=_source&meta_fields=_id&meta_fields=_type&meta_fields=_index&meta_fields=_score
The original code relies in
org.mitre.dsmiley.httpproxy.URITemplateProxyServlet.service
method, that used a list of parameters. This change uses a map with a list of values instead.It should be check to send a pull to https://github.com/mitre/HTTP-Proxy-Servlet to apply the changes in
org.mitre.dsmiley.httpproxy.URITemplateProxyServlet.service
. But this can take a while until merged and released in HTTP-Proxy-Servlet project.Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation