Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to static pages, configurable #7536

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

joachimnielandt
Copy link
Collaborator

@joachimnielandt joachimnielandt commented Dec 6, 2023

Added a configurable icon to the static pages. The icon is not shown when not supplied. Added help text indicating it needs to be a font-awesome icon.

image
image

@fxprunayre not sure what happens for submenus - the context leads me to believe only top / footer items are allowed for now, and that seems to work fine on my end.

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@joachimnielandt joachimnielandt changed the title add icon to static pages, configurable Add icon to static pages, configurable Dec 6, 2023
@fxprunayre fxprunayre added this to the 4.4.2 milestone Dec 18, 2023
@fxprunayre
Copy link
Member

@fxprunayre not sure what happens for submenus - the context leads me to believe only top / footer items are allowed for now, and that seems to work fine on my end.

Works fine in submenu too

image

eg.

[
  "gn-site-name-menu",
  "gn-portal-switcher",
  "gn-search-menu",
  "gn-map-menu",
  {
    "Quick search": [
      "dada"
    ]
  },
  "gn-contribute-menu",
  "gn-admin-menu"
]

@fxprunayre fxprunayre merged commit 21d22dd into geonetwork:main Dec 18, 2023
6 checks passed
juanluisrp added a commit that referenced this pull request Jan 18, 2024
The column is added automatically by Hibernate when GeoNetwork starts. Removing it
from the SQL because it makes the process to fail with
```
Duplicate column name "ICON"; SQL statement:
 ALTER TABLE public.spg_page ADD icon varchar NUL [42121-212]
```

Related to #7536.
fxprunayre pushed a commit that referenced this pull request Jan 18, 2024
The column is added automatically by Hibernate when GeoNetwork starts. Removing it
from the SQL because it makes the process to fail with
```
Duplicate column name "ICON"; SQL statement:
 ALTER TABLE public.spg_page ADD icon varchar NUL [42121-212]
```

Related to #7536.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants