Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoNetwork 4.x harvester #7579

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

GeoNetwork 4.x harvester #7579

wants to merge 9 commits into from

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Dec 24, 2023 •
edited
Loading

The current harvesters using GeoNetwork API doesn't support to harvest from GeoNetwork 4.

This change request adds a new type of harvester to harvest GeoNetwork 4 servers.

Ideally this change should be backported to 3.12.x, so old instances are also able to harvest GeoNetwork 4 servers.

Pending items:

  • Support authentication
  • Code refactor to share similar code with the GeoNetwork 3 harvester.
  • Support custom queriables. For now: any, title, abstract and keyword fields are supported

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.2 milestone Dec 24, 2023
@fxprunayre fxprunayre modified the milestones: 4.4.2, 4.4.3 Jan 3, 2024
@fxprunayre fxprunayre mentioned this pull request Jan 18, 2024
Open
34 tasks
@fxprunayre fxprunayre modified the milestones: 4.4.3, 4.4.4 Mar 13, 2024
@fxprunayre fxprunayre mentioned this pull request Apr 8, 2024
Closed
@fxprunayre fxprunayre modified the milestones: 4.4.4, 4.4.5 Apr 16, 2024
@fxprunayre fxprunayre modified the milestones: 4.4.5, 4.4.6 Jun 4, 2024
josegar74 and others added 3 commits September 5, 2024 14:32
@josegar74 @jodygarnett
Update docs/manual/docs/user-guide/harvesting/harvesting-geonetwork-2…
84cfd7b 
…0.md


@jodygarnett I don't think I've ever used GeoNetwork 2.0 since I started working on GeoNetwork, it seems like a very old version. We can probably get rid of that harvester, I doubt anyone uses that version.

Anyway your change looks fine.

Co-authored-by: Jody Garnett <[email protected]>
@josegar74 @jodygarnett
Update docs/manual/docs/user-guide/harvesting/harvesting-geonetwork-3…
0c82fd3 
…x.md

Co-authored-by: Jody Garnett <[email protected]>
@josegar74 @jodygarnett
Update docs/manual/docs/user-guide/harvesting/harvesting-geonetwork-4…
f5c229f 
…x.md

Co-authored-by: Jody Garnett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodygarnett jodygarnett jodygarnett left review comments

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
backport 3.12.x backport 4.2.x
Projects
None yet
Milestone
4.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@josegar74 @jodygarnett @fxprunayre