Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record view / Display WFS downloads for WFS online resources without a name defined #7626

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

josegar74
Copy link
Member

Online resources with OGC:WFS display a WFS selector to dowload the data in the metadata record view.

In main and 4.2.x requires that the online resource has a name defined. Otherwise, it's not displayed:

wfs-no-name-1

This behaviour was available in 3.12 version, but seems was removed in main:

<div data-ng-if="!isLayerProtocol(r)"
data-gn-no-map-wfs-download=""
data-typename=""
data-url="{{r.url | gnLocalized: lang}}">
</div>

This change restores the behaviour from 3.12 version:

wfs-no-name-2


Test case:

  1. Create an iso19139 metadata
  2. And an online resource with protocol OGC:WFS, providing the URL of a WFS service. Leave empty the name and description fields.
  3. Go to the metadata page:
  • Without the fix: The WFS download selector is not displayed.
  • With the fix: The WFS download selector is displayed.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working like 3.12, thanks!

@josegar74 josegar74 merged commit 172bce2 into geonetwork:main Jan 17, 2024
6 checks passed
josegar74 added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants