Metadata editor / Fix javascript error in the add thumbnail option when the metadata has 1 WMS layer

[josegar74]

Test case:

1. Create an iso19139 dataset metadata
2. Add an online resource with a WMS layer
3. Add an online resource and select the option Add a thumbnail in the dialog. Check the Javascript console:

• Without the fix:

Error: [orderBy:notarray] http://errors.angularjs.org/1.8.2/orderBy/notarray\?p0\=%7B%22resource%22%3A%7B%22ref%22%3A%22172%22%2C%22refParent%22%3A%22171%22%2C%22name%22%3A%222%22%2C%22url%22%3A%22https%3A%2F%2Fmaps-cartes.ec.gc.ca%2Farcgis%2Fservices%2FDMS%2FStressCumulatifLittorales%2FMapServer%2FWMSServer%3Frequest%3DGetCapabilities%26service%3DWMS%22%2C%22title%22%3A%22Metadata%20WMS%20layer%22%2C%22abstract%22%3A%22The%20ISO19115%20metadata%20standard%20is%20the%20preferred%20metadata%20standard%20to%20use.%20If%20unsure%20what%20templates%20to%20start%20with%2C%20use%20this%20one.%22%2C%22protocol%22%3A%22OGC%3AWMS%22%7D%7D
    at lib.js?v=65b94734a63ca8491dba95d7439baf1be02c2450:21:168

• With the fix: no javascript error is displayed

---

@fxprunayre not really related to this change, but to the Add thumbnails from map feature. Is this to hide the add thumbnails from map panel if the metadata doesn't have any WMS layer?

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/partials/addOnlinesrc.html

Lines 542 to 549 in 65b9473

	<div
	id="gn-addonlinesrc-thumbnail-warning"
	class="alert alert-warning"
	data-ng-show="layers == undefined"
	data-translate=""
	>
	noLayersForThumbnail
	</div>

This doesn't really work, independently of the value of scope.layers in

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcDirective.js

Line 681 in 65b9473

scope.layers = scope.gnCurrentEdit.layerConfig;

(no matter if in that line it is undefined or has a value), if you print that value in the HTML it is always prints [].

Debugging the code, scope.layers are reset in

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcDirective.js

Line 1123 in 65b9473

scope.layers = [];

after executing

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcDirective.js

Line 681 in 65b9473

scope.layers = scope.gnCurrentEdit.layerConfig;

I don't know that much this code, but seems like an unwanted side-effect?

---

Should not be this set to undefined to be consistent with the HTML check?

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcDirective.js

Line 617 in 65b9473

scope.layers = null;

If the purpose is to hide the panel if no WMS layers, I think we should unify the check either to undefined or empty array and check the side effect for reset protocol.

Doing some additional research, it seems scope.layers are used both in the WMS directive to select a WMS layer and also in the Add Thumbnail from map feature, that doesn't look good. I've changed

core-geonetwork/web-ui/src/main/resources/catalog/components/edit/onlinesrc/partials/addOnlinesrc.html

Lines 542 to 549 in 65b9473

	<div
	id="gn-addonlinesrc-thumbnail-warning"
	class="alert alert-warning"
	data-ng-show="layers == undefined"
	data-translate=""
	>
	noLayersForThumbnail
	</div>

To

data-ng-show="gnCurrentEdit.layerConfig == undefined"

And looks working fine like this:

1. If the metadata has WMS layers, are loaded in the map viewer to create the thumbnail

2. If the metadata has no WMS layers, a message No layer defined in record to generate thumbnail from is displayed (although needs some styling).

I think the assignment changed in this PR can be also completely removed, scope.layers should be used only to select layers from a WMS service.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation