Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSW Harvester / Avoid increment 2 metrics for a single metadata in certain conditions #8069

Merged
merged 2 commits into from
Sep 5, 2024
Merged

CSW Harvester / Avoid increment 2 metrics for a single metadata in certain conditions #8069

merged 2 commits into from
Sep 5, 2024

Conversation

josegar74
Copy link
Member

Retrieve metadata method increments metrics under certain conditions and returns null. Methods calling the retrieve metadata method increments additionally the unretrievable metric if null is returned. Sonarlint fixeas are already applied.

Fixes #8039

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74
CSW Harvester / Avoid increment 2 metrics for a single metadata in ce…
86a62b1 
…rtain conditions.

Retrieve metadata method increments metrics under certain conditions and returns null. Methods calling the retrieve metadata method increments additionally the unretrievable metric if null is returned. Sonarlint fixeas are already applied. Fixes geonetwork#8039
@josegar74 josegar74 added this to the 4.4.5 milestone May 19, 2024
@josegar74 josegar74 requested a review from fxprunayre May 19, 2024 08:33
tobias-hotz
tobias-hotz reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@tobias-hotz tobias-hotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Boxing/Unboxing related feedback, otherwise looking good! Thank you!

harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/csw/Aligner.java Outdated Show resolved Hide resolved
harvesters/src/main/java/org/fao/geonet/kernel/harvest/harvester/csw/Aligner.java Outdated Show resolved Hide resolved
@fxprunayre fxprunayre modified the milestones: 4.4.5, 4.4.6 Jun 13, 2024
tobias-hotz
tobias-hotz approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@tobias-hotz tobias-hotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, this look like a correct fix! Thanks

@josegar74 josegar74 merged commit 05b2e43 into geonetwork:main Sep 5, 2024
6 checks passed
@geonetworkbuild geonetworkbuild mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-hotz tobias-hotz tobias-hotz approved these changes

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
backport 4.2.x
Projects
None yet
Milestone
4.4.6
Development

Successfully merging this pull request may close these issues.

CSW Harvester: Inconsistent and Incorrect Metrics under certain conditions
3 participants
@josegar74 @tobias-hotz @fxprunayre