Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API / Improve parameter check for XSL conversion. #8201

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

fxprunayre
Copy link
Member

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre fxprunayre added this to the 4.4.6 milestone Jun 19, 2024
@fxprunayre fxprunayre mentioned this pull request Jun 19, 2024
10 tasks
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.

@fxprunayre I see some test failing, but can't find the option to relaunch the tests in the pull request. Can you check this before merging it?

@fxprunayre
Copy link
Member Author

@fxprunayre I see some test failing, but can't find the option to relaunch the tests in the pull request. Can you check this before merging it?

Aligning with main fix the unrelated failing test. Build in progress.

Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@josegar74 josegar74 merged commit c9164d0 into main Sep 2, 2024
8 of 9 checks passed
@fxprunayre fxprunayre deleted the 44-conversionparametercheck branch October 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants