Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor / Bounding polygon not saved #8230

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Editor / Bounding polygon not saved #8230

merged 1 commit into from
Jun 28, 2024

Conversation

fxprunayre
Copy link
Member

Related to JQuery update.
image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@fxprunayre
Editor / Polygon not saved
0c5155c 
Related to JQuery update.
@fxprunayre fxprunayre added this to the 4.4.6 milestone Jun 28, 2024
josegar74
josegar74 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@josegar74 josegar74 merged commit f0debae into main Jun 28, 2024
10 checks passed
@geonetworkbuild geonetworkbuild mentioned this pull request Jun 28, 2024
Merged
@fxprunayre fxprunayre deleted the 44-editorpolysave branch June 28, 2024 14:22
@jahow
Copy link
Contributor

jahow commented Jul 1, 2024

Out of curiosity, why is this change fixing the issue? I always though that self-closing html tags were allowed by browers and that it wouldn't make any difference.

@josegar74
Copy link
Member

@jahow, It's related to the upgrade of jQuery 3.7.1: https://jquery.com/upgrade-guide/3.5/#jquery-htmlprefilter-changes

@jahow
Copy link
Contributor

jahow commented Jul 1, 2024

Thanks, it's clearer now!

fxprunayre added a commit to SPW-DIG/metawal-core-geonetwork that referenced this pull request Jul 18, 2024
@fxprunayre
Editor / Polygon not saved (geonetwork#8230)
9645ae7 
Related to JQuery update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegar74 josegar74 josegar74 approved these changes

Assignees
No one assigned
Labels
backport 4.2.x
Projects
None yet
Milestone
4.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@fxprunayre @jahow @josegar74