-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard / ISO19139 / Fix removal of online source when multiple transfer options block are used. #8281
Conversation
transfer options block are used. Follow up of #7431
d248bf3
to
c8d298c
Compare
@fxprunayre I have made some changes locally to fix the issue with updating/deleting but still need to do some testing on the main branch to ensure it still works. I will push a PR against your branch shortly to show you the changes. |
I created a PR to be merged into this PR on the work I had done so far #8291. |
…_DigitalTransferOptions blocks.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on main, works well
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8281-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick c8d298ca4fd2f46052e7048575f3c4e6df1ba3ce,85af8e4d7e42e546df1b0e62b64871cbf1811318
# Push it to GitHub
git push --set-upstream origin backport-8281-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.x Then, create a pull request where the |
…sfer options block are used. (#8281) * Standard / ISO19139 / Fix removal of online source when multiple transfer options block are used. Follow up of #7431 * Fix online resource update/delete so that it supports multiple gmd:MD_DigitalTransferOptions blocks. --------- Co-authored-by: Ian Allen <[email protected]>
…sfer options block are used. (#8281) (#8297) * Standard / ISO19139 / Fix removal of online source when multiple transfer options block are used. Follow up of #7431 * Fix online resource update/delete so that it supports multiple gmd:MD_DigitalTransferOptions blocks. --------- Co-authored-by: François Prunayre <[email protected]>
Follow up of #7431
Address the case when multiple transfer option groups are used. Following discussion in #7431 (comment)
Can be tested with https://gist.github.com/fxprunayre/5641c474514a9d5159ef1479a030a117
Also add support for online sources in distributor blocks.
For ISO19115-3, it is a bit more complicated as online resources can be used in portrayal, feature catalogue, dq report, ... https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19115-3.2018/src/main/plugin/iso19115-3.2018/index-fields/link-utility.xsl#L78-L90
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentationFunded by EEA