Fix code paths that cause errors on Windows #8355
Conversation
Using the WSL on Windows means that the unit tests can be run. Due to IntelliJ's good integration into the WSL, this works very seamless with IntelliJ as well
|
@tobias-hotz the pull request looks good to me, but would be good to have a list of tests failing in Windows due to the line endings to update the code to use the current system line ending. |
|
Can we just fix the tests please rather than require Linux line feeds? windows is a supported environment is it not? We may as well test for it … If it helps we can setup a windows GitHub workflow to keep the tests passing correctly … |
This fixes some tests, like XslUtilTest and RemoveSourceMapUrlProcessorTest to include the expected line endings This also adjusts some wro4j classes to work correctly for windows. Previously, some code paths were hardcoded to only work on the D: drive on windows. This fixes all these issues by special casing file:/ URIs, as windows FS will throw an exception when trying to convert those to paths. Wro4j is also adjusted to take backslashes into account, as windows internally uses these instead of forward slashes for path separation. Finally, the ES enforcer script is updated to not use project.baseUri, as this causes compilation errors on windows. This is because these variables are filled before compiling, and on windows this results in paths like "C:\Builds\core-geonetwork", which is invalid, because the backslashes need to be escaped. Use the baseUri instead, as this always contains forward slashes.
tobias-hotz
changed the title
|
Thanks for your feedback. I've taken a look at the errors more closely, and it turns out there are more errors than just line endings. I've fixed all test failures in the lastest commit, so all unit tests now pass on windows. Please note that this also required some adjustment to non-test classes, as there were some errors/assumptions in wro4j regarding windows handling. Please read the commit message for more details. |
This test currently fails sometimes because of concurrent modifications. Adjust it so it uses proper thread safe constructs
|
I've also notices that MessageProducerTest sometimes fails. It seems like the test is not written thread-safe. I've fixed this test in the lastest commit to make it thread-safe |
Currently, when setting up the project as described on windows, you cannot run unit tests locally, as they assume LF line endings at various places.
Using the WSL on Windows means that these unit tests can be run.
Due to IntelliJ's good integration into the WSL, this works very seamless with IntelliJ as well.
Also include some minor fixes like incorrect links and outdated documentation
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by LGL BW