Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester / Simple URL / ODS improvement #8362

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Sep 9, 2024

  • Ignore "null" value
  • Add support for "metas/dcat"
  • Fix path for language and license when using v2 API
  • Add spatial and temporal extent when available
  • Add extra keywords based one "metas/dcat/temporal" and "metas/default/territory"
  • Add resource identifier
  • Add record count and geometry type
  • Add lineage and credit
  • Add references
  • Cleanup namespaces

image

Information displayed on ODS information page are now quite similar to the harvested content. Can probably be improved on publisher/creator/contributor element (to which contact contact_name/contact_email is attached to?) which is a bit unclear in the model.

Follow up of #7201 Related to #8359

Can be tested with

{"@id":"4284","@type":"simpleurl","owner":["70"],"ownerGroup":[14697],"ownerUser":["70"],"site":{"name":"odwb","uuid":"1f4e3e33-be43-486e-a371-f9fed31d4df1","account":{"use":false,"username":[],"password":[]},"url":"https://www.odwb.be/api/explore/v2.0/catalog/datasets?limit=10&offset=0&timezone=UTC&include_links=false&include_app_metas=false","icon":"blank.png","loopElement":"/datasets","numberOfRecordPath":"/total_count","recordIdPath":"/dataset/dataset_id","pageSizeParam":"limit","pageFromParam":"offset","toISOConversion":"schema:iso19115-3.2018:convert/fromJsonOpenDataSoft"},"content":{"validate":"NOVALIDATION","importxslt":"none","batchEdits":"[]"},"options":{"every":"0 0 0 ? * *","oneRunOnly":false,"overrideUuid":"SKIP","status":"active"},"privileges":[{"@id":"1","operation":[{"@name":"view"},{"@name":"dynamic"},{"@name":"download"}]}],"ifRecordExistAppendPrivileges":false,"info":{"lastRun":"2024-10-03T22:00:00.009288Z","running":false,"result":{"added":"0","atomicDatasetRecords":"0","badFormat":"0","collectionDatasetRecords":"0","datasetUuidExist":"1","privilegesAppendedOnExistingRecord":"0","doesNotValidate":"0","xpathFilterExcluded":"0","duplicatedResource":"0","fragmentsMatched":"0","fragmentsReturned":"0","fragmentsUnknownSchema":"0","incompatible":"0","recordsBuilt":"0","recordsUpdated":"0","removed":"0","serviceRecords":"0","subtemplatesAdded":"0","subtemplatesRemoved":"0","subtemplatesUpdated":"0","total":"1078","unchanged":"0","unknownSchema":"0","unretrievable":"0","updated":"1077","thumbnails":"0","thumbnailsFailed":"0","errors":[]}}}

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Service Public de Wallonie

@fxprunayre fxprunayre added this to the 4.4.6 milestone Sep 9, 2024
* Ignore "null" value
* Add support for "metas/dcat"
* Fix path for language when using v2 API
* Add spatial and temporal extent when available
* Add extra keywords based one "metas/dcat/temporal" and "metas/default/territory"
* Add resource identifier
* Add record count and geometry type
* Add lineage and credit
* Add references
* Cleanup namespaces

Follow up of #7201
Related to #8359
Copy link

sonarcloud bot commented Sep 9, 2024

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the harvester works fine.

The XSLT changes seem fine, although the mapping dataset/metas/dcat/temporal to a keyword is not very clear to me. But I don't know anything about the ODS format.

@fxprunayre fxprunayre merged commit 87a8e3d into main Oct 11, 2024
9 checks passed
@fxprunayre fxprunayre deleted the 44-odsharvesterimp branch October 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants