Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata detail page - hide history types selector when tasks (DOI) and workflow are disabled #8369

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

josegar74
Copy link
Member

Previously the metadata page displayed the Tasks and Events selector, even if DOI (Task) was disabled in the settings.

Screenshot 2024-09-16 at 13 32 58

With the change:

Screenshot 2024-09-16 at 13 32 34

With the change, if DOI is enabled, it works as previously displaying the selector.

Test case:

  1. Login as administrator and enable the metadata history and disable the DOI publication in the system settings.

  2. Load ISO19139 templates and create a metadata.

  3. Go to the metadata page:

  • Without the change: A selector for Tasks and Events is displayed
  • With the change: No selector is displayed.
  1. Enable the DOI publication in the system settings and go to the metadata page:
  • With the change: Check that the selector for Tasks and Events is displayed.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, the types selector is gone. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants