Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations / Temporal range / Avoid browser autocomplete on calendar #8380

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

fxprunayre
Copy link
Member

When using temporal range for aggregations

 resourceTemporalDateRange: {
                gnBuildFilterForRange: {
                  field: "resourceTemporalDateRange",
                  buckets: 2024 - 1970,
                  dateFormat: "YYYY",
                  dateSelectMode: "years",
                  vegaDateFormat: "%Y",
                  from: 1970,
                  to: 2024,
                  mark: "area"
                },
                meta: {
                  vega: "timeline",
                  collapsed: true
                }
              },

browser autocomplete may overlap with calendar

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Ifremer

…r field

When using temporal range for aggregations

```
 resourceTemporalDateRange: {
                gnBuildFilterForRange: {
                  field: "resourceTemporalDateRange",
                  buckets: 2024 - 1970,
                  dateFormat: "YYYY",
                  dateSelectMode: "years",
                  vegaDateFormat: "%Y",
                  from: 1970,
                  to: 2024,
                  mark: "area"
                },
                meta: {
                  vega: "timeline",
                  collapsed: true
                }
              },
```

browser autocomplete may overlap with calendar
@fxprunayre fxprunayre added this to the 4.4.6 milestone Sep 20, 2024
Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

The given example JSON has an error for the buckets, this has to be a number. So in this case 51 years in stead of a range 2021 - 1970.

It's already changed in the documentation

Copy link

sonarcloud bot commented Sep 23, 2024

@fxprunayre fxprunayre merged commit a5a1b49 into main Sep 23, 2024
9 of 10 checks passed
@fxprunayre fxprunayre deleted the 44-temporalrangeoverlapwithautocomplete branch September 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants