Harvesting: Clarify recordIdPath change in GN > 4.2.2 #240
Conversation
There was a problem hiding this comment.
Thanks for clarification and thanks @fxprunayre for investigations and checks.
| @@ -50,5 +50,7 @@ Adding a simple URL harvester | |||
| - *pageSizeParam* : ``rows`` | |||
| - *toISOConversion* : ``DKAN-to-ISO19115-3-2018`` | |||
|
|
|||
| Note: In GN versions > 4.2.2 the ``recordIdPath`` property needs to start with a ``/``. Schemas bearing similar names can be selected via a dropdown here. | |||
There was a problem hiding this comment.
Not a documenter expert, but if we start adding additional notes for each change in each release, readability of the doc in a couple of years will be a challenge, end users will have to read the top text and then applies all the notes with changes in each versions to have the full picture... Readability would be facilitated if the main text represent the current status and additional note highlight changes in past version so end user will have to read the note only if using old stuff? Also consider https://geonetwork-opensource.org/manuals/4.0.x/en/contributing/writing-documentation.html#versionadded-versionchanged-and-deprecated
There was a problem hiding this comment.
I agree.
Breaking changes should be documented somewhere though.
|
Don't forget to also highlight 4.2.4 new "features" of the ODS harvester geonetwork/core-geonetwork#7059
|
https://github.com/geonetwork/core-geonetwork/blob/main/CODE_OF_CONDUCT.md#our-standards
|
|
This PR was still open? It missed out on the mkdocs conversion ... can you make this change to core-geonetwork please |
PR clarifies documentation of
recordIdPathproperty for harvesting via a simple URL harvester.