Added Ordnance Survey providers #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS Maps API [get a free key](https://osdatahub.os.uk/) [OS Maps documentation](https://osdatahub.os.uk/docs/wmts/technicalSpecification) [OS attribution](https://www.ordnancesurvey.co.uk/business-government/licensing-agreements/copyright-acknowledgements)
martinfleis
reviewed
Apr 25, 2023
| "url": "https://api.os.uk/maps/raster/v1/zxy/Road_3857/{z}/{x}/{y}.png?key={key}", | ||
| "html_attribution": "Contains OS data © Crown copyright and database right {year}", | ||
| "attribution": "Contains OS data (C) Crown copyright and database right {year}", | ||
| "key": "<A valid OS MapsAPI Key. Get a free key here - https://osdatahub.os.uk/>", |
There was a problem hiding this comment.
Suggested change
| "key": "<A valid OS MapsAPI Key. Get a free key here - https://osdatahub.os.uk/>", | |
| "key": "<insert your valid OS MapsAPI Key. Get a free key here - https://osdatahub.os.uk/>", |
these placeholders need to start with "<insert your" as we use this string to check if a token is required or not (maybe a bit clumsily but that's how it is done now).
martinfleis
reviewed
Apr 26, 2023
| "Road_3857": { | ||
| "url": "https://api.os.uk/maps/raster/v1/zxy/Road_3857/{z}/{x}/{y}.png?key={key}", | ||
| "html_attribution": "Contains OS data © Crown copyright and database right {year}", | ||
| "attribution": "Contains OS data (C) Crown copyright and database right {year}", |
There was a problem hiding this comment.
I've now also noticed the {year} placeholder here. We currently don't support placeholders outside of the url parameter, so you will need to spell it out here. The attribution here shall always have the current year? We may need to figure out some autoupdating logic within https://github.com/geopandas/xyzservices/blob/main/provider_sources/_compress_providers.py
I can probably take care of it within the follow-up PR alognside tests.
this should be automatically updated
|
All good now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS Maps API
get a free key
OS Maps documentation
OS attribution