Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server host and port from pygeoapi configuration #1523

Closed
ricardogsilva opened this issue Jan 29, 2024 · 0 comments
Closed

Remove server host and port from pygeoapi configuration #1523

ricardogsilva opened this issue Jan 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ricardogsilva
Copy link
Member

pygeoapi configuration currently has the parameters:

  • server.bind.host
  • server.bind.port

These are used to specify how to run the pygeoapi web application server. However, given that these are just server initialization parameters, in my opinion, they should not be part of the configuration object, but rather specified at runtime, when initializing the web application server.

These parameters are not used anywhere except in the code that initializes the web application (flask, starlette, django).

Moreover, these parameters are simply not used if for example I use gunicorn to launch pygeoapi instead of pygeoapi serve, which is already the case on pygeoapi's docker image:

CONTAINER_HOST=${CONTAINER_HOST:=0.0.0.0}
CONTAINER_PORT=${CONTAINER_PORT:=80}

Describe the solution you'd like
I would like to have these parameters removed from the pygeoapi configuration and passed as either env variables or CLI parameters when calling pygeoapi serve.

@ricardogsilva ricardogsilva added the enhancement New feature or request label Jan 29, 2024
@ricardogsilva ricardogsilva closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant