Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed host and port from pygeoapi configuration #1525

Conversation

ricardogsilva
Copy link
Member

@ricardogsilva ricardogsilva commented Jan 29, 2024

This PR removes web application server initialization parameters from the pygeoapi configuration, specifically the server.bind section. This includes:

  • server.bind.host
  • server.bind.port

These now become initialization parameters, passed to pygeoapi serve. Included in this PR is a working implementation for all of:

  • flask
  • starlette
  • django

pygeoapi serve now accepts two optional parameters:

  • host - defaults to "127.0.0.1" - this is intentionally not set to "0.0.0.0" in order to prevent accidental exposure of private services.
  • port - defaults to 5000

Related issue / discussion

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva ricardogsilva marked this pull request as ready for review January 29, 2024 17:25
@ricardogsilva
Copy link
Member Author

Withdrawing this PR, as there seems to be appreciation for having these parameters in pygeoapi config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove server host and port from pygeoapi configuration
1 participant