Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate running of pygeoapi in serve cli command #1505

Conversation

ricardogsilva
Copy link
Member

Overview

This PR removes the additional calling of click's ctx.forward() which was causing duplicate launching of pygeoapi's web app when used via pygeoapi serve, as mentioned in #1504

Related issue / discussion

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva ricardogsilva marked this pull request as ready for review January 18, 2024 17:01
@tomkralidis tomkralidis added this to the 0.17.0 milestone Apr 6, 2024
@tomkralidis tomkralidis self-requested a review April 6, 2024 00:57
@tomkralidis tomkralidis added the bug Something isn't working label Apr 6, 2024
@tomkralidis tomkralidis merged commit 109d7c1 into geopython:master Apr 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygeoapi serve runs pygeoapi web application twice
2 participants