Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed encoding parameter from pygeoapi config #1524

Conversation

ricardogsilva
Copy link
Member

Overview

This PR removes the encoding configuration parameter. As discussed in #1521, this parameter only affected the charset of gzipped responses and was thus not being used very consistently. This proposed implementation simply removes this parameter from pygeoapi config and therefore makes gzipped responses use the default charset of utf-8, which is what the normal, non-gzipped responses were already doing.

Related issue / discussion

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva
Copy link
Member Author

CI error is not related to the changes in this PR - it is a manifestation of #1517

@ricardogsilva ricardogsilva marked this pull request as ready for review January 29, 2024 16:18
Copy link

github-actions bot commented May 5, 2024

This Pull Request has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label May 5, 2024
Copy link

As per RFC4, this Pull Request has been closed due to there being no activity for more than 90 days.

@github-actions github-actions bot closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue marked stale by stale-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not provide an option to choose charset for compressed GZIP responses
1 participant