Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra params fixes #1667 #1673

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Extra params fixes #1667 #1673

merged 8 commits into from
Aug 19, 2024

Conversation

Moritz-Langer
Copy link
Contributor

Overview

This PR contains the necessary adjustments for passing extra_params to providers and allow for custom behaviour in plugins.

Related Issue / discussion

Fixes #1667

Additional information

In the itemtypes a new variable is introduced. It contains a dictionary with unknown request parameters, basically anything can be passed to the request without changing behavior except there are no errors facing the client. The variable extra_params is then passed to the providers and accessible there.
Another oracle specific change is the provider definition is getting passed to the manipulation class for possible adjustments to queries and filtering using the geometry column. Because it could also be named diffenently the name must be accessible later on.

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis added this to the 0.18.0 milestone Jun 13, 2024
@Moritz-Langer Moritz-Langer deleted the extra_params branch August 1, 2024 08:03
@Moritz-Langer Moritz-Langer restored the extra_params branch August 1, 2024 08:30
@totycro totycro reopened this Aug 1, 2024
@tomkralidis tomkralidis self-requested a review August 19, 2024 11:38
@tomkralidis
Copy link
Member

Note: OGC API - Features supports additional query parameters that are not defined in OpenAPI via vendorSpecificParameters, which pygeoapi natively supports on OpenAPI generation for feature/record .../items definitions.

As a result, this PR was updated to support this approach on queries to itemtypes (which now applies to all feature/record providers). This PR was also tested against OAFeat CITE with no impact to conformance.

@tomkralidis tomkralidis merged commit 7e73434 into geopython:master Aug 19, 2024
4 checks passed
@tomkralidis tomkralidis deleted the extra_params branch August 19, 2024 12:17
@tomkralidis tomkralidis added enhancement New feature or request OGC API - Features OGC API - Features OGC API - Records OGC API - Records labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Features OGC API - Features OGC API - Records OGC API - Records
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass extra parameters to requests to allow for custom behaviour down the line
4 participants