fix breadcrumbs again (follow on of #1769) #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested review from
webb-ben,
pvgenuchten,
totycro,
kalxas,
francbartoli,
justb4,
doublebyte1,
jorgejesus,
GeoSander and
GregoryPetrochenkov-NOAA
doublebyte1
reviewed
Aug 3, 2024
| @@ -3,7 +3,7 @@ | |||
| {% block crumbs %}{{ super() }} | |||
| / <a href="{{ data['collections_path'] }}">{% trans %}Collections{% endtrans %}</a> | |||
| / <a href="{{ data['dataset_path'] }}">{{ data['title'] | truncate( 25 ) }}</a> | |||
| / <a href="./{{ data['id'] }}queryables">{% trans %}Queryables{% endtrans %}</a> | |||
There was a problem hiding this comment.
@tomkralidis I think you did not touch this line on #1769 and it seems to be working as expected?
| @@ -3,7 +3,7 @@ | |||
| {% block crumbs %}{{ super() }} | |||
| / <a href="{{ data['collections_path'] }}">{% trans %}Collections{% endtrans %}</a> | |||
| / <a href="{{ data['dataset_path'] }}">{{ data['title'] | truncate( 25 ) }}</a> | |||
| / <a href="./{{ data['id'] }}schema">{% trans %}Schema{% endtrans %}</a> | |||
| / <a href="{{ data['dataset_path'] }}/schema">{% trans %}Schema{% endtrans %}</a> | |||
There was a problem hiding this comment.
@tomkralidis same comment as for queryables.
|
@doublebyte1 previous to #1769, the breadcrumb href was empty because of missing properties in the data object passed. In some cases, this would cause a 404 when clicked depending on how pygeoapi was deployed (subpath, etc.). This PR (as well as #1769) follows the same HTML rendering pattern as .../items, to safeguard the href. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mea culpa; forgotten commit of #1769
Related Issue / discussion
#1769
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)