Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom esri token service #1813

Merged
merged 10 commits into from
Oct 1, 2024

Conversation

colin-geo
Copy link
Contributor

Overview

This PR updates the Esri provider so that a custom token generation service url can be passed through configuration to enable fetching of data from a self-hosted ArcGIS Server instance.

Related Issue / discussion

Fixes #1812

Additional information

None

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute bugfix to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis added this to the 0.18.0 milestone Sep 21, 2024
@tomkralidis tomkralidis added the OGC API - Features OGC API - Features label Sep 21, 2024
Copy link
Member

@webb-ben webb-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small changes. Can we also add the new fields to the ESRI OAF Provider documentation (https://github.com/geopython/pygeoapi/blob/master/docs/source/data-publishing/ogcapi-features.rst#esri-feature-service)

pygeoapi/provider/esri.py Outdated Show resolved Hide resolved
pygeoapi/provider/esri.py Outdated Show resolved Hide resolved
pygeoapi/provider/esri.py Outdated Show resolved Hide resolved
pygeoapi/provider/esri.py Outdated Show resolved Hide resolved
pygeoapi/provider/esri.py Outdated Show resolved Hide resolved
@tomkralidis tomkralidis modified the milestones: 0.18.0, 0.19.0 Sep 27, 2024
@colin-geo
Copy link
Contributor Author

I have incorporated the suggestions.

@tomkralidis tomkralidis merged commit e736fa3 into geopython:master Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability for Esri Feature Service provider to work with secured self-hosted service
3 participants