EDR CoverageJSON conformance fixes: time axis and demo data #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading from query bbox and reversing the order would not work anyway if not followed by reversing data (which is not cheap and would not do on default. It is visible on the sample data tests/data/coads_sst.nc where the start-stop swapping turn the data upside down.
there is no sense in reading it from source file once again
1. time axis shall be 't' in covjson, for backward compliance it can be set with 'time_axis_covjson' provider variable. if time_axis_covjson is not set the value is read from time_field which has default value read from the source file. 2. time axis is now list of values according to specification and it is now properly rendered on the html view of the query 3. typo in query.html to fix error with first layer being not generated
1.integrated changes from axis fix 2. dataType is float according to schema https://schemas.opengis.net/covjson/1.0/coveragejson.json (number is not valid, float, integer, string are) 3. parameter description as object according to schema https://schemas.opengis.net/covjson/1.0/coveragejson.json
coards_sst.nc data was shifted around 180 deg
Edr fixed axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
changes to confirm to https://schemas.opengis.net/covjson/1.0/coveragejson.json
Other:
Changes shall solve issues using https://covjson.org libraries, also on pygeoapi demo site.
Related Issue / discussion
#1782
Additional information
changes is not fully backward compatible with potential non-standard client using time as interval (which is breaking coveragejson-schema).
In addition to code changes, coads_sst.nc is fixed. Demo file had COADSX shifted west but not data which looks like this:
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)